changed pyodide version from 27.0 -> 27.7 - #55
sharma-anuj wants to merge 450 commits into
Conversation
- fixed 128 edge case of fucking ORs
Fixes tashifkhan#48 Closes tashifkhan#46
Fixed the timetable parsing error for jiit-128-3rd year
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Adding 2nd years timetable for 128 campus
|
@sharma-anuj is attempting to deploy a commit to the tashifkhan's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Updates the client-side Pyodide loader to use the intended CDN version so timetable generation uses the correct runtime.
Changes:
- Bump Pyodide CDN script URL from
v0.27.0tov0.27.7. - Bump Pyodide
indexURLfromv0.27.0tov0.27.7.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const script = document.createElement('script'); | ||
| script.src = 'https://cdn.jsdelivr.net/pyodide/v0.27.0/full/pyodide.js'; | ||
| script.src = 'https://cdn.jsdelivr.net/pyodide/v0.27.7/full/pyodide.js'; | ||
| script.async = true; | ||
| document.body.appendChild(script); |
There was a problem hiding this comment.
The Pyodide CDN URL is duplicated here (script.src) and again in loadPyodide({ indexURL }). To avoid future version mismatches (like the one this PR fixes), consider deriving both values from a single constant (e.g., a shared base URL/version) so they can’t drift.
| pyodideInstance = await window.loadPyodide({ | ||
| indexURL: 'https://cdn.jsdelivr.net/pyodide/v0.27.0/full/', | ||
| indexURL: 'https://cdn.jsdelivr.net/pyodide/v0.27.7/full/', | ||
| fullStdLib: false, |
There was a problem hiding this comment.
This changes the runtime-loaded Pyodide URL to v0.27.7, but the PWA runtime caching config (e.g., website/next.config.ts) and the generated service worker currently match v0.27.0 URLs. If left as-is, Pyodide assets may no longer be cached (and users with an existing SW may keep stale caches). Update the caching URL pattern(s) to the same version/base URL to keep behavior consistent.
|
fair lets add this in a constants.ts or something then upgrade it i suppose |
Fix timetable generation issue caused by Pyodide version mismatch
Issue
Timetable generation was failing due to a mismatch in the Pyodide version being loaded.
Fix
Updated the project setup to use the correct Pyodide version.