fix(core): correct asset protocol multi-range responses (fix: #15837) - #15838
Open
lazerg wants to merge 2 commits into
Open
fix(core): correct asset protocol multi-range responses (fix: #15837)#15838lazerg wants to merge 2 commits into
lazerg wants to merge 2 commits into
Conversation
lazerg
changed the title
Contributor
Package Changes Through 85d7a46There are 14 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-bundler with minor, tauri-build with minor, tauri-macos-sign with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor, @tauri-apps/api with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-range
asset://responses had three problems. The multipart body was terminated with an opening boundary (--boundary) instead of the close-delimiter RFC 2046 asks for (--boundary--). The sniffed file mime type set before the range branch stayed on the response alongsidemultipart/byteranges, becauseBuilder::headerappends rather than replaces, so clients reading the firstContent-Typeparsed the envelope as the file itself. And the status stayed200 OKwhile the body was partial.Single-range requests, which is what
<video>and<audio>normally send, were never affected, so this only shows up on clients asking for more than one range. Added a unit test covering all three.Closes #15837.