fix(acl): improve error handling for non-finite floats - #15893
Open
Br1skyy wants to merge 1 commit into
Open
Conversation
Fixes tauri-apps#15477. TOML config parsing now rejects NaN/±Infinity early with a clear assert message, and the JSON conversion uses a descriptive panic message instead of a bare unwrap() failure. Previous attempt in tauri-apps#15482 mapped non-finite floats to null, but that was rejected because silently dropping values can mask bugs.
Br1skyy
force-pushed
the
fix/nonfinite-float-panic
branch
from
August 19, 2026 00:56
e8482d8 to
83a38c7
Compare
Br1skyy
changed the title
Contributor
Package Changes Through 83a38c7There are 14 changes which include tauri-utils with minor, tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-build with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-bundler with minor, tauri-macos-sign with minor, @tauri-apps/api with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
|
Hey, thanks for the PR, I would probably want to go with #15484 though that removes this struct entirely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15477.
acl::Valuetoserde_json::Valuewas calling.unwrap()onfrom_f64()which gives a bare panic for NaN and ±Infinity. This adds an early reject at the TOML entry point with a clear assert message, and a descriptive expect message on the JSON conversion so the panic is understandable. Previous attempt in #15482 mapped these to null but that was closed because silently dropping values can mask bugs.