Skip to content

docs: document the Release PR check approval step - #48

Merged
tbaur merged 1 commit into
mainfrom
docs/release-pr-approval-gate
Aug 30, 2026
Merged

tbaur merged 1 commit into
mainfrom
docs/release-pr-approval-gate

Conversation

@tbaur

@tbaur tbaur commented Aug 30, 2026

Copy link
Copy Markdown
Owner

GitHub's bot-created pull requests change means the Release PR's workflow runs are now created but held until a user with write access approves them. Merging the Release PR first finalises those runs as failure with zero jobs and no logs, which reads as a broken release when nothing actually broke.

Summary

  • Add an Approve the Release PR checks section: click "Approve and run" on the Checks tab before merging.
  • Correct the older claim that GitHub never triggers workflows for PRs opened by the built-in token. It does now, it just holds them.
  • Note that there is no CLI for this gate, and that the approval is needed on every release.

Test plan

  • Docs only, no code paths touched.
  • Confirmed on the next release that approving before merge leaves the checks green.

GitHub's June 2026 bot-created pull requests change means the Release
PR's workflow runs are created but held until someone with write access
approves them. Merging first finalises them as failures with no jobs and
no logs, which reads as a broken release.

Record the approval step, and correct the older claim that workflows are
never triggered for PRs opened by the built-in token.
@tbaur
tbaur merged commit ab03888 into main Aug 30, 2026
7 checks passed
@tbaur
tbaur deleted the docs/release-pr-approval-gate branch August 30, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant