ci: run Tests and OSV on pull requests only - #50
Merged
Merged
Conversation
main is protected and every change already arrives through a PR. Running the same checks again on the merge was a second bill for the same tree. Release stays on push to main: that is the workflow that tags and publishes. The publish job still builds, lints and tests before npm publish. OSV's weekly scan still updates the security tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis protected. Every change already comes through a PR, so Tests and OSV onpushtomainwere a second run of the same tree.pull_requestandmerge_grouponlymainCodeQL is left alone. Its
mainrun is the security-tab baseline, not a duplicate test.ci:so this does not cut a release.Test plan