chore

Author: tchapi

.github/workflows/ci.yml

@@ -200,6 +200,13 @@ jobs:
           php bin/console doctrine:database:create --if-not-exists --env=test
           php bin/console doctrine:migrations:migrate --no-interaction --env=test
           php bin/console doctrine:schema:validate --env=test
+          # Full chain check: roll every migration back down, then all the way up again.
+          # Nothing else ever runs the down() methods, so a broken rollback (wrong column
+          # name, duplicated ALTER clause, invalid cast) stays invisible until an operator
+          # actually needs to roll back.
+          php bin/console doctrine:migrations:migrate first --no-interaction --env=test
+          php bin/console doctrine:migrations:migrate --no-interaction --env=test
+          php bin/console doctrine:schema:validate --env=test
 
       - name: Run migrations (PostgreSQL)
         if: matrix.database == 'postgresql'
@@ -209,6 +216,13 @@ jobs:
           php bin/console doctrine:database:create --if-not-exists --env=test
           php bin/console doctrine:migrations:migrate --no-interaction --env=test
           php bin/console doctrine:schema:validate --skip-sync --env=test
+          # Full chain check: roll every migration back down, then all the way up again.
+          # Nothing else ever runs the down() methods, so a broken rollback (wrong column
+          # name, duplicated ALTER clause, invalid cast) stays invisible until an operator
+          # actually needs to roll back.
+          php bin/console doctrine:migrations:migrate first --no-interaction --env=test
+          php bin/console doctrine:migrations:migrate --no-interaction --env=test
+          php bin/console doctrine:schema:validate --skip-sync --env=test
 
       - name: Run migrations (SQLite)
         if: matrix.database == 'sqlite'
@@ -217,6 +231,13 @@ jobs:
         run: |
           php bin/console doctrine:migrations:migrate --no-interaction --env=test
           php bin/console doctrine:schema:validate --skip-sync --env=test
+          # Full chain check: roll every migration back down, then all the way up again.
+          # Nothing else ever runs the down() methods, so a broken rollback (wrong column
+          # name, duplicated ALTER clause, invalid cast) stays invisible until an operator
+          # actually needs to roll back.
+          php bin/console doctrine:migrations:migrate first --no-interaction --env=test
+          php bin/console doctrine:migrations:migrate --no-interaction --env=test
+          php bin/console doctrine:schema:validate --skip-sync --env=test
 
   smoke-test:
     name: Application Smoke Test

migrations/Version20191202091507.php

@@ -28,6 +28,8 @@ public function down(Schema $schema): void
     {
         $this->skipIf('mysql' !== $this->connection->getDatabasePlatform()->getName(), 'This migration is specific to \'mysql\'. Skipping it is fine.');
 
-        $this->addSql('ALTER TABLE calendarinstances CHANGE access access SMALLINT NOT NULL, CHANGE share_invitestatus share_invitestatus INT NOT NULL, CHANGE timezone timezone LONGTEXT DEFAULT NULL, CHANGE timezone timezone VARCHAR(255) CHARACTER SET utf8mb4 DEFAULT \'NULL\' COLLATE `utf8mb4_unicode_ci`');
+        // NB: `timezone` is restored to its original VARCHAR(255); a VTIMEZONE blob longer than
+        // that would be rejected by MySQL rather than silently truncated.
+        $this->addSql('ALTER TABLE calendarinstances CHANGE access access SMALLINT NOT NULL, CHANGE share_invitestatus share_invitestatus INT NOT NULL, CHANGE timezone timezone VARCHAR(255) DEFAULT NULL');
     }
 }

migrations/Version20231001214112.php

@@ -30,8 +30,8 @@ public function down(Schema $schema): void
     {
         $this->skipIf('postgresql' !== $this->connection->getDatabasePlatform()->getName(), 'This migration is specific to \'postgresql\'. Skipping it is fine.');
 
-        $this->addSql("ALTER TABLE calendarobjects ALTER COLUMN calendardata TYPE BYTEA DEFAULT NULL USING convert_from(calendardata, 'utf8')");
-        $this->addSql("ALTER TABLE cards ALTER COLUMN carddata TYPE BYTEA DEFAULT NULL USING convert_from(carddata, 'utf8')");
-        $this->addSql("ALTER TABLE schedulingobjects ALTER COLUMN calendardata TYPE BYTEA DEFAULT NULL USING convert_from(calendardata, 'utf8')");
+        $this->addSql("ALTER TABLE calendarobjects ALTER COLUMN calendardata TYPE BYTEA USING convert_to(calendardata, 'utf8')");
+        $this->addSql("ALTER TABLE cards ALTER COLUMN carddata TYPE BYTEA USING convert_to(carddata, 'utf8')");
+        $this->addSql("ALTER TABLE schedulingobjects ALTER COLUMN calendardata TYPE BYTEA USING convert_to(calendardata, 'utf8')");
     }
 }

migrations/Version20260131161930.php

@@ -44,9 +44,9 @@ public function down(Schema $schema): void
 
         // Revert public = true back to ACCESS_PUBLIC (10)
         if ('postgresql' === $engine) {
-            $this->addSql('UPDATE calendarinstances SET access = 10 WHERE is_public = TRUE');
+            $this->addSql('UPDATE calendarinstances SET access = 10 WHERE public = TRUE');
         } else {
-            $this->addSql('UPDATE calendarinstances SET access = 10 WHERE is_public = 1');
+            $this->addSql('UPDATE calendarinstances SET access = 10 WHERE public = 1');
         }
 
         if ('mysql' === $engine) {