Conversation
Strengthen the stable preview verifier to validate OAuth client metadata values, DPoP settings, and latest-play JSON shape. Document the stricter verifier and update todo.md with the current OAuth preflight evidence.
Document that the stable preview can resolve a handle and reach the account provider authorization page with the sigilyph client metadata. The remaining OAuth QA now explicitly requires credentialed callback and session-restore verification.
Persist the resolved OAuth issuer and rebuild callback/restore clients from the callback issuer so non-bsky PDS sign-ins do not reuse the initial client after redirect.
Move Popfeed work to feature/popfeed-sync and remove the Popfeed tracker entry from the active feature branch handoff.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 10, 2026
Closed
mmattbtw
added this pull request to stack #228
September 10, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore issuer clients and verify public oauth metadata. This groups the existing commits by chronology and the area they change.
Part 22 of 33 replacing #113. Review this PR against
feature/obbpr-21-scrobble-editing. Merge the stack from oldest to newest. The originalobbprbranch remains unchanged atd3cf209d6ab5ae6d3b2b7ac353b3dbb7d54fe133for rollback.Commits in this group:
Validation: checked the branch ancestry and confirmed that the final stack tree exactly matches
obbpr. This split preserves existing commits and merge history; no source edits or new build/test runs. Intermediate snapshots have not been independently validated, so these PRs start as drafts. Historical main merges are preserved.Stack navigation: