Skip to content

Commit a4cad9e

Browse files
docs: record Copilot review resolution and mathematical set difference fix for PR #39429
1 parent 66250e1 commit a4cad9e

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

‎scratch/pr_39429_copilot_reply.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
Thank you for catching this! You are completely right.
2+
3+
### Resolution:
4+
1. **Mathematical Set Difference**: Removed the raw edge count check (`connected_edges < expected_input_ports`). We now collect all unique incoming destination port IDs in a `std::unordered_set<size_t> connected_ports` and compute the strict set difference against declared input ports:
5+
$$\mathcal{M} = \mathcal{P}_{\text{in}} \setminus \mathcal{D}$$
6+
If `!missing_ports.empty()`, validation immediately throws an `ov::Exception` listing all missing XML port IDs. This is completely invariant to duplicate destination edges and non-contiguous port numbering.
7+
2. **Regression & Positive Tests Added**:
8+
- Added `duplicate_destination_edges_with_noncontiguous_ports_throws_descriptive_exception` in `src/frontends/ir/tests/disconnected_port_diagnostic_test.cpp` testing declared ports `10` and `20` with duplicate incoming edges targeting port `10`. Confirmed that it immediately throws and reports missing port `[20]`.
9+
- Added `valid_connected_ports_deserializes_successfully` confirming zero regressions on valid graphs.
10+
11+
Pushed in commit a795d087.

0 commit comments

Comments
 (0)