Refine console output - #112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place path in prompt.
We now render the fully qualified path, and have made an adjustment that each segment of a qualified paths is separated by a
/character. This matches expectations, and although collapsing a procedure and it's step was cute, it was harder to parse visually. Using the separator consistently at all layers considerably simplifies understanding the path. Also, the full nested scope of the location is shown; although a procedure can be invoked anywhere in a document, it's fully qualified path is that reflecting the top-level procedure, section, procedure, step etc it is a part ofWe now get the user confirm completion on exit from each scope. While it is momentarily convenient to automatically close a procedure if all its steps are done, or likewise for a section, the judgment that a scope is actually complete is best left up to the user.
Finally, we also request confirmation before running external commands via
exec().