Support places in Attribute scopes - #72
Merged
Merged
Conversation
Member
Author
istathar
marked this pull request as ready for review
August 29, 2025 14:34
Member
Author
|
Added the dummy minimal test I had to examples/golden and testing showed we had the parser but forgot the formatter! Yeay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had the notion of both roles and places in Attributes in Technique v0, but so far in v1 we'd only implemented role Attributes with the
@rolenotation. This branch adds^place, using the caret we're now using as the marker for place Attributes.