Repository navigation
Codex/fix bling response validation - #3
Conversation
Mira PR WalkthroughThis PR fixes response validation in the generated Bling ERP API models. It introduces a new/adjusted custom field type in Confidence: 4/5 ◉◉◉◉○ Safe to merge
Key files to review:
50 files reviewed · 2 comments (
|
There was a problem hiding this comment.
Mira Review Summary
The new BlingDatetime validator pipeline in src/bling_erp_api/models/fields.py ships without any test coverage, meaning a regression in the sentinel normalization, America/Sao_Paulo localization, DST handling, or JSON serialization would silently mis-parse timestamps. Separately, naive timestamps falling in the repeated hour of a historical DST-end transition silently resolve to the DST offset (fold=0 default), which may misinterpret Bling's stored time by one hour, and this resolution choice is currently undocumented.
Key Issues
| Issue | Location | |
|---|---|---|
| 🔴 | The new BlingDatetime validator pipeline (sentinel normalization, America/Sao_Paulo localization, DST handling, JSON serialization) ships with no tests; a regression would silently mis-parse every tracking timestamp. | src/bling_erp_api/models/fields.py:78 |
| 🔴 | Naive timestamps inside the repeated hour at a historical DST-end transition resolve to the DST offset (fold=0 default), which may misinterpret Bling's stored time by one hour; the choice is undocumented and untested. | src/bling_erp_api/models/fields.py:74 |
No description provided.