fix(node): pace peer block imports - #1383
Open
decofe wants to merge 1 commit into
Open
Conversation
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
decofe
requested review from
0xKitsune,
0xrusowsky,
adityapk00,
klkvr,
legion2002 and
mattsse
as code owners
September 3, 2026 17:49
Collaborator
|
cyclops audit fast |
|
cc @adityapk00 Cyclops audit event published. View workflow run Config: config: |
tempoxyz-bot
reviewed
Sep 3, 2026
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review
This PR adds follower-side pacing before importing peer blocks. I found one actionable liveness issue: the new wait is based on an untrusted peer header before consensus validation and can be amplified through accepted backfill responses.
Reviewer Callouts
- ⚡ Backfill response budgeting: Please confirm the backfill coordinator enforces requested height/page bounds or equivalent per-request limits, so repeated response frames cannot amplify expensive pre-validation work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
cargo test -p zone-node --libcargo +nightly fmt --all --checkcargo +nightly clippy -p zone-node --lib --testsPrompted by: @adityapk00