Skip to content

fix(node): pace peer block imports - #1383

Open
decofe wants to merge 1 commit into
mainfrom
centaur/pace-peer-block-import-1788456824
Open

fix(node): pace peer block imports#1383
decofe wants to merge 1 commit into
mainfrom
centaur/pace-peer-block-import-1788456824

Conversation

@decofe

@decofe decofe commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

  • wait for the follower wall clock to catch up before importing a slightly future-dated peer block
  • cap the delay at one second so consensus validation still rejects materially future timestamps
  • add a focused test covering follower-side timestamp pacing

Tests

  • cargo test -p zone-node --lib
  • cargo +nightly fmt --all --check
  • cargo +nightly clippy -p zone-node --lib --tests

Prompted by: @adityapk00

Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
@adityapk00

Copy link
Copy Markdown
Collaborator

cyclops audit fast

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

cc @adityapk00

Cyclops audit event published. View workflow run

Config: config: default, iterations: 1, hours: default

@tempoxyz-bot tempoxyz-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ Cyclops Review

This PR adds follower-side pacing before importing peer blocks. I found one actionable liveness issue: the new wait is based on an untrusted peer header before consensus validation and can be amplified through accepted backfill responses.

Reviewer Callouts
  • Backfill response budgeting: Please confirm the backfill coordinator enforces requested height/page bounds or equivalent per-request limits, so repeated response frames cannot amplify expensive pre-validation work.

Comment thread crates/node/src/replication.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants