Repository navigation
feat: reward fulfilment tracker and personal bests - #1104
Merged
Merged
Conversation
Reward fulfilment (#1098): with reward_fulfilment_enabled on, an approved reward stays owed until a parent marks it handed over (approvals card, panel Today page) or the child taps Got it! on their card; parents are reminded after reward_fulfilment_reminder_days and every that many days after. New mark_reward_delivered service, taskmate_reward_delivered event and reward_owed notification. Streak freezes, timed unlocks and wishes are never tracked. Personal bests (#1099): per-child records (longest streak, best day and week in points, most chores in a day, biggest single award) checked after every approval, recomputed on undo/reject, celebrated with taskmate_personal_best, an opt-in personal_best notification and a tier-2 celebration; new Personal Bests card and a new-record banner on the child card. Strings in all ten locales; wiki pages and reference tables updated.
github-actions
Bot
added
documentation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reward fulfilment (#1098): with reward_fulfilment_enabled on, an approved
reward stays owed until a parent marks it handed over (approvals card,
panel Today page) or the child taps Got it! on their card; parents are
reminded after reward_fulfilment_reminder_days and every that many days
after. New mark_reward_delivered service, taskmate_reward_delivered event
and reward_owed notification. Streak freezes, timed unlocks and wishes are
never tracked.
Personal bests (#1099): per-child records (longest streak, best day and
week in points, most chores in a day, biggest single award) checked after
every approval, recomputed on undo/reject, celebrated with
taskmate_personal_best, an opt-in personal_best notification and a tier-2
celebration; new Personal Bests card and a new-record banner on the child
card. Strings in all ten locales; wiki pages and reference tables updated.
New in this PR: setting
reward_fulfilment_enabled+reward_fulfilment_reminder_days, servicemark_reward_delivered, eventstaskmate_reward_delivered/taskmate_personal_best, notification typesreward_owed(default on) /personal_best(off), new cardtaskmate-personal-bests-card, child card optionshow_personal_bests. Docs: wiki/Reward-Fulfilment.md, wiki/Personal-Bests.md.Tested on the dev instance (owed list on the approvals card and panel, Got it! on the child card, record banner and Personal Bests card).
Closes #1098
Closes #1099