Repository navigation
ci(release-guard): allow for the built Manual bundle in taskmate.zip - #1139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release guard compares
taskmate.zipfile-for-file withcustom_components/taskmateat the tag. Since the in-panel Manual (#1136), the zip also carrieswww/manual/manual.json(.gz), whichrelease-zip.ymlbuilds fromwiki/and which is gitignored, so it can never be in the tag. The guard therefore failed on v7.4.0 even though the zip was correct.www/manual/; every other file is still checked byte-for-byte against the tag.manual.jsonmust be present, itsversionmust equal the tag, andmanual.json.gzmust hold the same JSON.Tested against the real v7.4.0 zip and tag (passes), a zip whose Manual says 7.3.1 (fails), and a zip with a changed
const.py(fails).