Skip to content

fix(vpc): allow ALL for security group rule port range - #4329

Open
july2993 wants to merge 1 commit into
tencentcloudstack:masterfrom
july2993:fix_port
Open

july2993 wants to merge 1 commit into
tencentcloudstack:masterfrom
july2993:fix_port

Conversation

@july2993

Copy link
Copy Markdown
Contributor

What

fix #4328

Why

Type of change

  • New SDKv2 resource / data source
  • New framework resource / data source
  • Modification to an existing resource / data source
  • Bug fix
  • Refactor / internal-only change
  • Documentation only

Checklist

  • make build succeeds locally
  • make fmt produces no diff
  • make lint passes (or pre-existing failures are unrelated)
  • make check-mux passes (SDKv2 + framework mux compatibility)
  • Confirmed the resource/data source type name is not already
    registered in the other stack
    (CI's make check-mux enforces
    this; please double-check before opening the PR)
  • Acceptance tests added or updated (or skipped with justification)
  • Website docs updated under website/docs/r/ or website/docs/d/
  • go.mod changes are accompanied by go mod vendor in the same commit
  • Changelog entry added under .changelog/<PR>.txt (if user-facing)

Notes for reviewers

@SevenEarth

SevenEarth commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Thank you very much for the PR. It is worth noting that the tencentcloud_security_group_rule resource has been deprecated and is no longer maintained; we recommend using the tencentcloud_security_group_rule_set resource instead.
You can view it through the following link: https://registry.terraform.io/providers/tencentcloudstack/tencentcloud/latest/docs/resources/security_group_rule_set

@july2993

Copy link
Copy Markdown
Contributor Author

tencentcloud_security_group_rule_set

thinks for the reply, but sometimes we do not want to own the whole security group, tencentcloud_security_group_rule_set will delete rules controlled not by tencentcloud_security_group_rule_set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tencentcloud_security_group_rule: port_range rejects ALL although the provider uses ALL as the default value

2 participants