Conversation
- Add Sensitive:true to secret_key, backup_secret_key, secret_access_key fields
- Add nil checks for Create/Modify/Delete API response in v2 resource
- Fix Read method log order to preserve d.Id() before SetId('')
- Add response.Response nil check in DescribeTeoL7AccRuleById service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues found in the TEO L7 Accelerated Rules evaluation:
Sensitive fields: Added Sensitive:true to secret_key, backup_secret_key, and secret_access_key fields to prevent plaintext leakage in state files and logs.
Create method (v2): Added proper nil checks for result, result.Response, and RuleIds in the CreateL7AccRules API call; return NonRetryableError when responses are empty.
Read method (v1+v2): Fixed log order to preserve d.Id() before calling SetId for debugging.
Update method (v2): Added nil check for result and result.Response in the ModifyL7AccRule API call.
Delete method (v2): Added nil check for result and result.Response in the DeleteL7AccRules API call.
Service layer: Added nil check for response.Response in DescribeTeoL7AccRuleById.