Repository navigation
Conversation
Avoid testing selectors for unrelated tags when resolving implicit roles. Keep existing selector matching and rule priority within each tag. Co-Authored-By: Codex <noreply@openai.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 85d321d:
|
scttcper
marked this pull request as ready for review
September 17, 2026 06:46
Co-Authored-By: Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only check implicit-role selectors for the element's tag. Keep the existing selector matching and specificity order.
Named-button query on a 501-element fixture, median of nine paired batches:
matches()calls drop from 5,300 to 1,200 per query. These are synthetic query timings, not whole-suite gains. Textbox cases benefit less, with regressions of 3.3% in Happy DOM and 1.2% in WebKit.Full evidence and runner: 30 benchmark cases, 35,320 behavior comparisons with no differences. Node stayed at 24.14, below jsdom 30.1's declared 24.15 minimum.