Repository navigation
chore: use staged publishing - #21
Merged
Merged
Conversation
commit: |
There was a problem hiding this comment.
🟢 Approval recommended
The focused wrapper and workflow changes preserve command arguments and have no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR routes automated releases through npm staged publishing while allowing release and tag creation before staging approval.
Changes:
- Add an npm wrapper that redirects
publishtonpm stage publishand forwards other commands unchanged. - Update the release job to Node.js
>=24.18.0 <25and add the wrapper toPATH.
| File | Description |
|---|---|
scripts/wrap-staged/npm |
Redirects publishing to staging and removes its own PATH entry to avoid recursion. |
.github/workflows/ci.yml |
Updates the release job’s Node.js version and enables the npm wrapper. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's okay if a release/tag are created and staged publishing is then rejected. I can always clean up by hand. Staged publishing is worth the hassle.