[WIP]Check if storeapi series is nil before iterating - #19
Open
4n4nd wants to merge 1 commit into
Open
Conversation
bwplotka
requested changes
Oct 2, 2020
bwplotka
left a comment
bwplotka
left a comment
Member
There was a problem hiding this comment.
I think we need bit different behaviour but it's close (:
| @@ -91,6 +91,10 @@ func (i *iterator) Next() bool { | |||
| } | |||
|
|
|||
| i.currentSeries = seriesResp.GetSeries() | |||
Member
There was a problem hiding this comment.
Hey, nil is actually ok because we have different responses: warnings hints as well..
We should gather warnings at least and log them and otherwise ignore non series frames (:
Contributor
Author
There was a problem hiding this comment.
umm what do you suggest how do we prevent Seg faults then?
Member
There was a problem hiding this comment.
As in 99% cases you can always check how we deal with this on Thanos (:
4n4nd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #18