Skip to content

[WIP]Check if storeapi series is nil before iterating #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4n4nd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP]Check if storeapi series is nil before iterating #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/series/storeapi/storeapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ func (i *iterator) Next() bool {
}

i.currentSeries = seriesResp.GetSeries()

@bwplotka bwplotka Oct 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, nil is actually ok because we have different responses: warnings hints as well..

We should gather warnings at least and log them and otherwise ignore non series frames (:

@4n4nd 4n4nd Oct 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm what do you suggest how do we prevent Seg faults then?

@bwplotka bwplotka Oct 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in 99% cases you can always check how we deal with this on Thanos (:

https://github.com/thanos-io/thanos/blob/49dad93ed67210374939aedd7a8f849a60375906/pkg/query/querier.go#L153

if i.currentSeries == nil {
i.err = errors.Errorf("Received nil series from Series Response")
return false
}
return true
}

Expand Down