Skip to content

Commit d9079ca

Browse files
committed
fix!: bypass middle modules
similar to a68bb8f, expose structs and enums from inner modules
1 parent aa1fd34 commit d9079ca

10 files changed

Lines changed: 135 additions & 122 deletions

File tree

examples/responder/responder.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use tokio::{
1111
use tracing::*;
1212
use twamp_rs::server::Server;
1313
use twamp_rs::session_reflector::SessionReflector;
14-
use twamp_rs::twamp_control::request_tw_session::RequestTwSession;
14+
use twamp_rs::twamp_control::RequestTwSession;
1515

1616
#[derive(Debug)]
1717
pub struct Responder {

src/control_client/mod.rs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
use crate::twamp_control::accept::Accept;
2-
use crate::twamp_control::accept_session::AcceptSession;
3-
use crate::twamp_control::request_tw_session::RequestTwSession;
4-
use crate::twamp_control::security_mode::Mode;
5-
use crate::twamp_control::server_greeting::ServerGreeting;
6-
use crate::twamp_control::server_start::ServerStart;
7-
use crate::twamp_control::set_up_response::SetUpResponse;
8-
use crate::twamp_control::start_ack::StartAck;
9-
use crate::twamp_control::start_sessions::StartSessions;
10-
use crate::twamp_control::stop_sessions::StopSessions;
1+
use crate::twamp_control::Accept;
2+
use crate::twamp_control::AcceptSession;
3+
use crate::twamp_control::RequestTwSession;
4+
use crate::twamp_control::SecurityMode;
5+
use crate::twamp_control::ServerGreeting;
6+
use crate::twamp_control::ServerStart;
7+
use crate::twamp_control::SetUpResponse;
8+
use crate::twamp_control::StartAck;
9+
use crate::twamp_control::StartSessions;
10+
use crate::twamp_control::StopSessions;
1111
use anyhow::{Result, anyhow};
1212
use deku::prelude::*;
1313
use std::mem::size_of;
@@ -90,7 +90,7 @@ impl ControlClient {
9090
/// Creates a `SetUpResponse`, converts to bytes and sends it out on `TWAMP-Control`.
9191
pub async fn send_set_up_response(&mut self) -> Result<()> {
9292
info!("Preparing to send Set-Up-Response");
93-
let set_up_response = SetUpResponse::new(Mode::Unauthenticated);
93+
let set_up_response = SetUpResponse::new(SecurityMode::Unauthenticated);
9494
debug!("Set-Up-Response: {:?}", set_up_response);
9595
let encoded = set_up_response.unwrap().to_bytes().unwrap();
9696
self.stream

src/server/mod.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1+
use crate::twamp_control::Accept;
2+
use crate::twamp_control::AcceptSession;
13
use crate::twamp_control::Messages;
2-
use crate::twamp_control::accept::Accept;
3-
use crate::twamp_control::accept_session::AcceptSession;
4-
use crate::twamp_control::request_tw_session::RequestTwSession;
5-
use crate::twamp_control::security_mode::Mode;
6-
use crate::twamp_control::server_start::ServerStart;
7-
use crate::twamp_control::start_ack::StartAck;
8-
use crate::twamp_control::start_sessions::StartSessions;
9-
use crate::twamp_control::stop_sessions::StopSessions;
10-
use crate::twamp_control::{server_greeting::ServerGreeting, set_up_response::SetUpResponse};
4+
use crate::twamp_control::RequestTwSession;
5+
use crate::twamp_control::SecurityMode;
6+
use crate::twamp_control::ServerStart;
7+
use crate::twamp_control::StartAck;
8+
use crate::twamp_control::StartSessions;
9+
use crate::twamp_control::StopSessions;
10+
use crate::twamp_control::{ServerGreeting, SetUpResponse};
1111
use anyhow::Result;
1212
use deku::prelude::*;
1313
use std::time::Duration;
@@ -130,7 +130,7 @@ impl Server {
130130
/// Creates a `ServerGreeting`, converts to bytes and sends it out on `TWAMP-Control`.
131131
pub async fn send_server_greeting(&mut self) -> Result<ServerGreeting> {
132132
info!("Sending ServerGreeting");
133-
let server_greeting = ServerGreeting::new(&[Mode::Unauthenticated]);
133+
let server_greeting = ServerGreeting::new(&[SecurityMode::Unauthenticated]);
134134
debug!("ServerGreeting: {:?}", server_greeting);
135135
let encoded = server_greeting.to_bytes().unwrap();
136136
self.socket.write_all(&encoded[..]).await?;

src/twamp_control/accept_session.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use super::accept::Accept;
1+
use super::Accept;
22
use deku::prelude::*;
33

44
/// Response for a Request-TW-Session command.

src/twamp_control/mod.rs

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,25 @@
1-
pub mod accept;
2-
pub mod accept_session;
3-
pub mod command_number;
1+
mod accept;
2+
mod accept_session;
3+
mod command_number;
44
mod constants;
5-
pub mod request_tw_session;
6-
pub mod security_mode;
7-
pub mod server_greeting;
8-
pub mod server_start;
9-
pub mod set_up_response;
10-
pub mod start_ack;
11-
pub mod start_sessions;
12-
pub mod stop_sessions;
5+
mod request_tw_session;
6+
mod security_mode;
7+
mod server_greeting;
8+
mod server_start;
9+
mod set_up_response;
10+
mod start_ack;
11+
mod start_sessions;
12+
mod stop_sessions;
1313

14+
pub use accept::*;
15+
pub use accept_session::*;
16+
pub use command_number::*;
1417
pub use constants::*;
18+
pub use request_tw_session::*;
19+
pub use security_mode::*;
20+
pub use server_greeting::*;
21+
pub use server_start::*;
22+
pub use set_up_response::*;
23+
pub use start_ack::*;
24+
pub use start_sessions::*;
25+
pub use stop_sessions::*;

src/twamp_control/security_mode.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use num_enum::IntoPrimitive;
66
#[derive(Clone, Debug, Default, PartialEq, Copy, IntoPrimitive, DekuRead, DekuWrite)]
77
#[repr(u32)]
88
#[deku(type = "u32", endian = "endian", ctx = "endian: deku::ctx::Endian")]
9-
pub enum Mode {
9+
pub enum SecurityMode {
1010
/// Unused.
1111
/// Control-Client **should** close the connection.
1212
/// Server **may** close the connection immediately.
@@ -33,10 +33,10 @@ mod tests {
3333

3434
#[test]
3535
fn should_have_valid_discriminants() {
36-
let reserved: u32 = Mode::Reserved.into();
37-
let unauthenticated: u32 = Mode::Unauthenticated.into();
38-
let authenticated: u32 = Mode::Authenticated.into();
39-
let encrypted: u32 = Mode::Encrypted.into();
36+
let reserved: u32 = SecurityMode::Reserved.into();
37+
let unauthenticated: u32 = SecurityMode::Unauthenticated.into();
38+
let authenticated: u32 = SecurityMode::Authenticated.into();
39+
let encrypted: u32 = SecurityMode::Encrypted.into();
4040
assert_eq!(reserved, 0u32);
4141
assert_eq!(unauthenticated, 1u32);
4242
assert_eq!(authenticated, 2u32);

0 commit comments

Comments
 (0)