Skip to content

Commit b3cf544

Browse files
authored
Merge pull request #2430 from the-guild-org/powerkiki
Revert attempt to update to Apollo Client 4.2
2 parents aebf112 + 8788839 commit b3cf544

6 files changed

Lines changed: 90 additions & 130 deletions

File tree

‎.changeset/lazy-lights-live.md‎

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎.changeset/wide-carrots-dance.md‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎packages/apollo-angular/src/apollo.ts‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Observable } from 'rxjs';
22
import { Inject, Injectable, NgZone, Optional } from '@angular/core';
33
import type { OperationVariables } from '@apollo/client';
4-
import { ApolloClient, ErrorPolicy } from '@apollo/client';
4+
import { ApolloClient } from '@apollo/client';
55
import { QueryRef } from './query-ref';
66
import { APOLLO_FLAGS, APOLLO_NAMED_OPTIONS, APOLLO_OPTIONS } from './tokens';
77
import type { EmptyObject, Flags, NamedOptions } from './types';
@@ -18,10 +18,7 @@ export declare namespace Apollo {
1818
TVariables extends OperationVariables = EmptyObject,
1919
> = ApolloClient.QueryOptions<TData, TVariables>;
2020

21-
export type QueryResult<
22-
TData = unknown,
23-
TErrorPolicy extends ErrorPolicy | undefined = undefined,
24-
> = ApolloClient.QueryResult<TData, TErrorPolicy>;
21+
export type QueryResult<TData = unknown> = ApolloClient.QueryResult<TData>;
2522

2623
export type MutateOptions<
2724
TData = unknown,
@@ -100,7 +97,7 @@ export class ApolloBase {
10097
TVariables extends OperationVariables = EmptyObject,
10198
>(
10299
options: Apollo.WatchFragmentOptions<TFragmentData, TVariables>,
103-
): Observable<Apollo.WatchFragmentResult<TFragmentData | null>> {
100+
): Observable<Apollo.WatchFragmentResult<TFragmentData>> {
104101
const { useZone, ...opts } = options;
105102
const obs = this.ensureClient().watchFragment<TFragmentData, TVariables>({ ...opts });
106103

‎packages/apollo-angular/src/only-complete-data.ts‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ type CompleteFragment<TData> = {
77
} & GetDataState<TData, 'complete'>;
88

99
type ForWatchFragment<TData> = OperatorFunction<
10-
ApolloClient.WatchFragmentResult<TData | null>,
11-
ApolloClient.WatchFragmentResult<TData | null> & CompleteFragment<NonNullable<TData>>
10+
ApolloClient.WatchFragmentResult<TData>,
11+
CompleteFragment<TData>
1212
>;
1313

1414
/**
@@ -54,10 +54,5 @@ export const onlyComplete = onlyCompleteData;
5454
* Same as `onlyCompleteData()` but for `Apollo.watchFragment()`.
5555
*/
5656
export function onlyCompleteFragment<TData>(): ForWatchFragment<TData> {
57-
return filter(
58-
(
59-
result,
60-
): result is ApolloClient.WatchFragmentResult<TData | null> &
61-
CompleteFragment<NonNullable<TData>> => result.dataState === 'complete',
62-
);
57+
return filter((result): result is CompleteFragment<TData> => result.dataState === 'complete');
6358
}

‎packages/demo/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"@angular/core": "^20.3.0",
1818
"@angular/platform-browser": "^20.3.0",
1919
"@angular/router": "^20.3.0",
20-
"@apollo/client": "^4.2.7",
20+
"@apollo/client": "^4.0.1",
2121
"apollo-angular": "workspace:*",
2222
"typescript": "~5.8.0"
2323
}

0 commit comments

Comments
 (0)