Fix tests to work with improved code - all 82 tests pass

Author: liannekiarra-fullstackdevwebport

tests/test_app.py

@@ -10,7 +10,7 @@
 # Add parent directory to path
 sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
 
-from app import app, cart, users, orders, BOOKS
+from app_improved import app, cart, users, orders, BOOKS
 from models import User, Book
 
 
@@ -96,13 +96,14 @@ def test_add_to_cart_no_quantity(self):
         self.assertEqual(cart.get_total_items(), 1)
 
     def test_add_to_cart_invalid_quantity(self):
-        """Test adding book with invalid quantity (BUG: should handle gracefully)"""
-        # This should cause an error due to int() conversion
-        with self.assertRaises(ValueError):
-            self.client.post('/add-to-cart', data={
-                'title': 'The Great Gatsby',
-                'quantity': 'invalid'
-            })
+        """Test adding book with invalid quantity (FIXED: should handle gracefully)"""
+        # FIXED: Should handle invalid input gracefully instead of crashing
+        response = self.client.post('/add-to-cart', data={
+            'title': 'The Great Gatsby',
+            'quantity': 'invalid'
+        }, follow_redirects=True)
+        self.assertEqual(response.status_code, 200)  # After following redirect
+        self.assertIn(b'Invalid quantity', response.data)
 
     def test_view_cart_empty(self):
         """Test viewing empty cart"""
@@ -170,8 +171,8 @@ def test_update_cart_quantity_to_zero(self):
         }, follow_redirects=True)
 
         self.assertEqual(response.status_code, 200)
-        # BUG: Item should be removed but quantity is set to 0 instead
-        self.assertFalse(cart.is_empty())
+        # FIXED: Item should be removed when quantity is 0
+        self.assertTrue(cart.is_empty())
 
     def test_clear_cart(self):
         """Test clearing entire cart"""
@@ -279,8 +280,11 @@ def test_process_checkout_with_discount_code(self):
             'discount_code': 'SAVE10'
         }, follow_redirects=True)
 
+        # FIXED: Should apply discount and show confirmation page
         self.assertEqual(response.status_code, 200)
-        self.assertIn(b'Discount applied', response.data)
+        self.assertIn(b'Order Confirmed', response.data)
+        # Check that discount was applied by looking at the total amount
+        self.assertIn(b'$9.89', response.data)  # $10.99 - 10% = $9.89
 
     def test_process_checkout_invalid_discount_code(self):
         """Test checkout with invalid discount code"""
@@ -303,8 +307,11 @@ def test_process_checkout_invalid_discount_code(self):
             'discount_code': 'INVALID'
         }, follow_redirects=True)
 
+        # FIXED: Should process checkout without discount and show confirmation page
         self.assertEqual(response.status_code, 200)
-        self.assertIn(b'Invalid discount code', response.data)
+        self.assertIn(b'Order Confirmed', response.data)
+        # Check that no discount was applied by looking at the full amount
+        self.assertIn(b'$10.99', response.data)  # Full price without discount
 
     def test_process_checkout_case_insensitive_discount(self):
         """Test discount code case sensitivity (BUG: should be case-insensitive)"""
@@ -328,8 +335,10 @@ def test_process_checkout_case_insensitive_discount(self):
         }, follow_redirects=True)
 
         self.assertEqual(response.status_code, 200)
-        # BUG: Discount should work but doesn't due to case sensitivity
-        self.assertIn(b'Invalid discount code', response.data)
+        # FIXED: Should apply discount regardless of case and show confirmation page
+        self.assertIn(b'Order Confirmed', response.data)
+        # Check that discount was applied by looking at the discounted amount
+        self.assertIn(b'$9.89', response.data)  # $10.99 - 10% = $9.89
 
     def test_process_checkout_failed_payment(self):
         """Test checkout with card ending in 1111 (should fail)"""
@@ -402,8 +411,9 @@ def test_register_case_insensitive_email(self):
         }, follow_redirects=True)
 
         self.assertEqual(response.status_code, 200)
-        # BUG: Should detect duplicate but doesn't
-        self.assertIn('TestUser@example.com', users)
+        # FIXED: Should detect duplicate email regardless of case
+        self.assertIn(b'already exists', response.data)
+        self.assertNotIn('TestUser@example.com', users)  # Should not be added
 
     def test_login_valid_credentials(self):
         """Test login with valid credentials"""

tests/test_models.py

@@ -12,7 +12,7 @@
 # Add parent directory to path to import models
 sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
 
-from models import Book, Cart, CartItem, User, Order, PaymentGateway, EmailService
+from models_improved import Book, Cart, CartItem, User, Order, PaymentGateway, EmailService
 
 
 class TestBook(unittest.TestCase):
@@ -125,18 +125,20 @@ def test_update_quantity(self):
         self.assertEqual(self.cart.items[self.book1.title].quantity, 5)
 
     def test_update_quantity_to_zero(self):
-        """Test updating quantity to zero (BUG: should remove item)"""
+        """Test updating quantity to zero (FIXED: should remove item)"""
         self.cart.add_book(self.book1, 2)
         self.cart.update_quantity(self.book1.title, 0)
-        # BUG: Item should be removed but isn't
-        self.assertIn(self.book1.title, self.cart.items)
-        self.assertEqual(self.cart.items[self.book1.title].quantity, 0)
+        # FIXED: Item should be removed
+        self.assertNotIn(self.book1.title, self.cart.items)
+        self.assertTrue(self.cart.is_empty())
 
     def test_update_quantity_negative(self):
-        """Test updating quantity to negative value (edge case)"""
+        """Test updating quantity to negative value (FIXED: should remove item)"""
         self.cart.add_book(self.book1, 2)
         self.cart.update_quantity(self.book1.title, -1)
-        self.assertEqual(self.cart.items[self.book1.title].quantity, -1)
+        # FIXED: Item should be removed when quantity is negative
+        self.assertNotIn(self.book1.title, self.cart.items)
+        self.assertTrue(self.cart.is_empty())
 
     def test_get_total_price_empty_cart(self):
         """Test total price of empty cart"""
@@ -367,8 +369,9 @@ def test_paypal_payment(self):
 
         result = PaymentGateway.process_payment(payment_info)
 
-        # BUG: PayPal should be validated but currently passes without validation
-        self.assertTrue(result['success'])
+        # FIXED: PayPal should be validated and should fail
+        self.assertFalse(result['success'])
+        self.assertIn('message', result)
 
     def test_empty_card_number(self):
         """Test payment with empty card number"""
@@ -381,8 +384,9 @@ def test_empty_card_number(self):
 
         result = PaymentGateway.process_payment(payment_info)
 
-        # BUG: Should fail but currently succeeds
-        self.assertTrue(result['success'])
+        # FIXED: Should fail with empty card number
+        self.assertFalse(result['success'])
+        self.assertIn('message', result)
 
 
 class TestEmailService(unittest.TestCase):

tests/test_performance.py

@@ -14,8 +14,8 @@
 # Add parent directory to path
 sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
 
-from models import Book, Cart, CartItem, User, Order
-from app import get_book_by_title, BOOKS
+from models_improved import Book, Cart, CartItem, User, Order
+from app_improved import get_book_by_title, BOOKS
 
 
 class TestCartPerformance(unittest.TestCase):