Fixes #39627 - Support OpenVox Agent for FreeBSD - #11162
Open
adamruzicka wants to merge 1 commit into
Open
Conversation
adamruzicka
force-pushed
the
freebsd-puppet
branch
from
August 14, 2026 14:13
2f484ce to
de502a4
Compare
adamruzicka
commented
Aug 17, 2026
|
|
||
| if os_family == 'Freebsd' | ||
| freebsd_package = host_param_true?('enable-puppet6') ? 'puppet6' : 'puppet5' | ||
| freebsd_package = host_param_true?('enable-puppet8') ? 'puppet8' : 'openvox-agent8' |
Contributor
Author
There was a problem hiding this comment.
See https://github.com/theforeman/foreman/pull/10928/changes#r3783394970 for reasoning
There was a problem hiding this comment.
Pull request overview
Updates the FreeBSD Puppet agent bootstrap template to default to OpenVox 8 while still allowing Puppet 8 via host parameter, and modernizes service enablement using sysrc.
Changes:
- Switch FreeBSD default agent package from Puppet 5/6 selection to
openvox-agent8by default, withpuppet8whenenable-puppet8is set. - Replace direct
/etc/rc.confappend withsysrcfor enabling the Puppet service on FreeBSD.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This changes from puppet 5 (default) or puppet 6 (parameter) to openvox 8 (default) or puppet 8 (parameter). Additionally this moves from writing to an rc.conf file to using the sysrc utility when setting up the agent to run as a service.
adamruzicka
force-pushed
the
freebsd-puppet
branch
from
August 22, 2026 09:14
de502a4 to
f803d93
Compare
lzap
approved these changes
Aug 25, 2026
lzap
left a comment
lzap
left a comment
Member
There was a problem hiding this comment.
Weird this is passing without any snapshot test, is this even used? Ah we might not be doing FreeBSD snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes from puppet 5 (default) or puppet 6 (parameter) to openvox 8 (default) or puppet 8 (parameter).
Additionally this moves from writing to an rc.conf file to using the sysrc utility when setting up the agent to run as a service.