Fixes #36596 - Update existing array variable overrides - #802
Open
jakduch wants to merge 1 commit into
Open
Conversation
Choose between creating and updating an override from the host lookup value instead of the merged effective value. Assisted-By: Codex 5.6 Sol High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36596.
The host details editor decided whether to create or update an override from the effective value's source. For merged array variables, that source can remain a host group even when a host-specific lookup value already exists. Editing the variable again then attempted to create the same matcher and failed with
has already been taken.Choose the operation from the actual lookup value for the host matcher. Reuse the same lookup-by-matcher rule for deleting overrides, without comparing a stored array to its merged effective value.
Add a regression fixture and test for editing an existing host override whose effective array also contains inherited values.
Testing
AI usage disclosure
Per the community discussion on AI policy, the issue was investigated and the changes, tests, and PR wording were prepared with the assistance of Codex 5.6 Sol High. The resulting changes were reviewed before submitting. The commit also includes an
Assisted-Bytrailer.