Skip to content

Confirm which tax basis the SLS transportationAmount expects #40

Description

@anoziere

Request/LabelRequest.php:105-115 passes the order shipping to the SLS Service block:

new Service(
    $productCode,
    new DateTime(),
    $order->getRef(),
    $order->getPostage(),
    3,
    ...
)

order.postage is stored tax included. La Poste's SLS documentation should be checked for what transportationAmount expects: if it is a tax-excluded amount, the value has to be $order->getUntaxedPostage(), and every label produced so far declares a shipping cost inflated by its VAT.

Flagging it rather than changing it, since only the SLS contract can settle which basis is right.

order.postage is stored tax included; the core side of that convention is documented in thelia/thelia#3698.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions