Skip to content

docs(thelia2): document generateRedirectFromRoute pitfall with module… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anoziere merged 1 commit into from
Aug 7, 2026
Merged

docs(thelia2): document generateRedirectFromRoute pitfall with module… #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/thelia/skills/thelia2/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ Access from `BaseModule`: `$this->getContainer()` (`L143`), `$this->getRequest()
### 4.4 Smarty back-office
- Theme `default`; module override in `{module}/templates/backOffice/default/...`.
- 8-10 native BO hooks (`main.head-css`, `main.before-topbar`, `categories.row`, `order-edit.bill-top`, `customer-edit.top`, `modules.config-js`...).
- `BaseAdminController` helpers: `validateForm()`, `generateRedirectFromRoute()`, `generateErrorRedirect()`, `generateSuccessRedirect()`, `getParserContext()`.
- `BaseAdminController` helpers: `validateForm()`, `generateRedirectFromRoute()` (core `router.admin` routes ONLY — see pitfall below for module routes), `generateErrorRedirect()`, `generateSuccessRedirect()`, `getParserContext()`.
- Details: [references/smarty-back.md](references/smarty-back.md)

### 4.5 Hooks
Expand Down Expand Up @@ -297,6 +297,7 @@ Access from `BaseModule`: `$this->getContainer()` (`L143`), `$this->getRequest()
| 10 | Native Doctrine AP filters incompatible with Propel resource | runtime crash | 7 Thelia custom Propel filters only |

Bonus criticals:
- `generateRedirectFromRoute('my_module_route')` in a module controller throws `RouteNotFoundException` ("Unable to generate a URL for the named route"): `BaseAdminController` generates URLs against `router.admin` (core routes only), which does not contain the module's `#[Route]` attribute routes — request matching works, URL generation does not. Use `$this->generateRedirect(URL::getInstance()->absoluteUrl('/admin/my_module/...'))` instead. Trap: the action (delete/toggle...) executes BEFORE the redirect, so it silently succeeds despite the 500
- `registerHooks()` outside transaction -> module active without hooks if exception (`BaseModule.php:111`)
- `ORDER_BEFORE_CREATE` does not exist; use `ORDER_BEFORE_PAYMENT` (`TheliaEvents.php:296`)
- `CART_ADDITEM` (productId payload) vs `AFTER_CARTADDITEM` (cart only, productId absent): choose based on the payload you need
Expand Down
2 changes: 1 addition & 1 deletion plugins/thelia/skills/thelia2/references/smarty-back.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Excerpts from `templates/backOffice/default/admin-layout.tpl` and pages:
| Helper | Signature | Role |
|---|---|---|
| `validateForm` | `validateForm(BaseForm $form, $expectedMethod = null): \Symfony\Component\Form\Form` | CSRF + method + Symfony validators; throws `FormValidationException` otherwise. Exceptions caught in `ParserContext` (`BaseController.php:263-271`) |
| `generateRedirectFromRoute` | `generateRedirectFromRoute(string $route, array $params = [])` | Redirect to admin URL |
| `generateRedirectFromRoute` | `generateRedirectFromRoute(string $route, array $params = [])` | Redirect to admin URL — **core `router.admin` routes only**: module `#[Route]` names raise `RouteNotFoundException`, use `generateRedirect(URL::getInstance()->absoluteUrl('/admin/...'))` in module controllers |
| `generateErrorRedirect` | `generateErrorRedirect(BaseForm $form)` | Redirect to form `error_url` with errors persisted in `ParserContext` |
| `generateSuccessRedirect` | `generateSuccessRedirect(BaseForm $form)` | Redirect to `success_url` |
| `getParserContext` | `getParserContext(): ParserContext` | Push errors / variables for Smarty |
Expand Down
Loading