Final version bump to v5.2.5 for public release.

Author: y000yal

.github/sync-file-list.yml

@@ -1,4 +1,4 @@
-wpeverest/user-registration-pro@master:
+wpeverest/user-registration-pro@develop:
     - assets
     - includes
     - modules

.github/workflows/sync.yml

@@ -2,7 +2,7 @@ name: Sync Files To Pro
 on:
     push:
         branches:
-            - master
+            - develop
         workflow_dispatch:
 jobs:
     sync:

CHANGELOG.txt

@@ -1,11 +1,12 @@
-= 5.2.5    - 07/07/2026 =
+= 5.2.5    - 08/07/2026 =
 * Enhance  - Defer expiry to period end.
 * Enhance  - Pin Stripe subscription payment method for reliable renewals.
 * Fix      - User and admin email order.
 * Fix      - Payment fail case for paypal.
 * Fix      - Lost Password Carrot adjustment.
 * Fix      - Unnecessary payment retry checks.
 * Fix      - Required Nonce Error on registration.
+* Fix      - Fatal error on WooCommerce shop page.
 * Fix      - Setup wizard membership duration issue.
 * Fix      - Loader timing issue during registration.
 * Fix      - Unwanted settings showing up in free version.
@@ -19,6 +20,7 @@
 * Fix      - Use server membership state for multiple-membership policy.
 * Fix      - Block tampered PayPal payments from activating memberships.
 * Fix      - Stripe payment and nonce validation failed on Membership form.
+* Fix      - Field Visibility add-on hides fields in My Account read-only profiles.
 * Fix      - Security: prevent unauthorized login during membership signup payment.
 * Fix      - Check coupon eligibility before discount on public membership purchase.
 * Fix      - Super admin bypass missing for admin content access in membership rules.

assets/js/admin/ur-notice.min.js

@@ -3,6 +3,8 @@
 	var elements = {};
 	var stripe_mode_validated = false;
 	var validated_stripe_pm_id = null;
+	var stripe_card_state = { complete: false, error: null };
+	var stripe_validation_in_progress = false;
 	var ur_membership_frontend_utils = {
 		/**
 		 * Appends a spinner element to the specified element.
@@ -478,6 +480,25 @@
 							};
 
 							elements.card.emit("change", event);
+						} else if (!stripe_card_state.complete) {
+							// Card element has input but Stripe.js reports it
+							// incomplete/invalid (e.g. missing postal code).
+							// Block the submit here, before the registration
+							// request creates the user, instead of letting
+							// confirmCardPayment fail afterwards.
+							no_errors = false;
+							var incomplete_event = {
+								error: {
+									message:
+										stripe_card_state.error &&
+										stripe_card_state.error.message
+											? stripe_card_state.error.message
+											: urmf_data.labels
+													.i18n_empty_card_details
+								}
+							};
+
+							elements.card.emit("change", incomplete_event);
 						}
 					}
 				});
@@ -1660,6 +1681,7 @@
 			});
 		},
 		handle_authorize_multiple_purchase: function (
+			submittedData,
 			selected_membership_id,
 			selected_pg,
 			btn,
@@ -1681,7 +1703,11 @@
 							action: "user_registration_membership_add_multiple_membership",
 							selected_membership_id: data.selected_membership_id,
 							selected_pg: data.selected_pg,
-							ur_authorize_data: data.ur_authorize_data
+							ur_authorize_data: data.ur_authorize_data,
+							form_data: submittedData.form_data,
+							coupon: submittedData.coupon,
+							form_id: submittedData.form_id,
+							type: data.type
 						},
 						{
 							success: function (response) {
@@ -2157,6 +2183,13 @@
 			elements.card.addEventListener("change", function (e) {
 				stripe_mode_validated = false;
 				validated_stripe_pm_id = null;
+				// Genuine Stripe change events always carry a boolean `complete`;
+				// synthetic events emitted from validate_membership_form don't,
+				// and must not overwrite the tracked card state.
+				if (typeof e.complete !== "undefined") {
+					stripe_card_state.complete = e.complete;
+					stripe_card_state.error = e.error || null;
+				}
 				if (e.error) {
 					stripe_settings.show_stripe_error(e.error.message);
 				} else {
@@ -2269,7 +2302,6 @@
 						prepare_members_data,
 						form_response
 					);
-					ur_membership_frontend_utils.hide_payment_processing_overlay();
 				});
 		},
 		update_order_status: function (
@@ -3177,9 +3209,61 @@
 						return;
 					}
 
-					stripe_settings.show_stripe_error(
-						urmf_data.labels.i18n_validating_stripe_card
+					// Prevent double submission
+					if (stripe_validation_in_progress) return;
+					stripe_validation_in_progress = true;
+
+					var $submit_button =
+						$form && $form.length
+							? $form.find(".ur-submit-button")
+							: $(".ur-submit-button");
+					$submit_button.prop("disabled", true);
+					$submit_button
+						.find("span")
+						.addClass("ur-front-spinner");
+
+					// The core submit handler's `#stripe-errors:visible` guard is
+					// what stops this first submit from racing straight to
+					// registration while the card is still being validated (the
+					// button's own disabled state only protects *later* clicks,
+					// not this first synchronous pass). We still need that
+					// element to exist, but the user already sees the button's
+					// spinner, so this one is collapsed out of the layout
+					// entirely (zero size, taken out of normal flow) rather
+					// than just visually hidden — otherwise the `.user-
+					// registration-error` class's own border/padding still
+					// renders an empty box and reserves a gap. jQuery's
+					// `:visible` only requires the element to generate a box
+					// (any `getClientRects()` entry) — it doesn't need to have
+					// non-zero size — so this still satisfies that guard.
+					var $validating_marker = $(
+						'<label id="stripe-errors" class="user-registration-error" role="alert" style="position:absolute;width:0;height:0;margin:0;padding:0;border:0;overflow:hidden;"></label>'
 					);
+					$membership_registration_form
+						.find(".stripe-container")
+						.closest(".ur_membership_frontend_input_container")
+						.append($validating_marker);
+
+					// show_stripe_error() reuses an existing #stripe-errors
+					// element via .show(), which only toggles `display` and
+					// would leave the marker's collapsing inline styles in
+					// place — silently hiding a real error. Remove the marker
+					// first so a genuine failure always renders a fresh,
+					// fully-visible label.
+					var show_real_stripe_error = function (message) {
+						$membership_registration_form
+							.find("#stripe-errors")
+							.remove();
+						stripe_settings.show_stripe_error(message);
+					};
+
+					var release_submit = function () {
+						stripe_validation_in_progress = false;
+						$submit_button.prop("disabled", false);
+						$submit_button
+							.find("span")
+							.removeClass("ur-front-spinner");
+					};
 
 					elements.stripe
 						.createPaymentMethod({
@@ -3188,9 +3272,10 @@
 						})
 						.then(function (pmResult) {
 							if (pmResult.error) {
-								stripe_settings.show_stripe_error(
+								show_real_stripe_error(
 									pmResult.error.message
 								);
+								release_submit();
 								return;
 							}
 
@@ -3209,23 +3294,30 @@
 										validated_stripe_pm_id =
 											pmResult.paymentMethod.id;
 										stripe_mode_validated = true;
+										stripe_validation_in_progress = false;
 										if ($form && $form.length) {
 											$form
 												.find(".ur-submit-button")
 												.prop("disabled", false);
 											$form.submit();
 										}
 									} else {
-										stripe_settings.show_stripe_error(
+										show_real_stripe_error(
 											response.data &&
 												response.data.message
 												? response.data.message
 												: urmf_data.labels
 														.i18n_stripe_mode_error
 										);
+										release_submit();
 									}
 								}
-							);
+							).fail(function () {
+								release_submit();
+							});
+						})
+						.catch(function () {
+							release_submit();
 						});
 				}
 			);