Fix - Stop retrying a Stripe subscription that no longer exists

A resource_missing error means the gateway subscription is gone for good
(deleted, or created under the other API mode), but retry_subscription()
handled it like a transient failure, so the daily cron re-attempted the
same impossible lookup every day. One live site logged 1596 of these for
a single row holding a test-mode id under live keys.

Mark the gateway subscription unrecoverable on resource_missing and bail
out early on the next run. Keying the marker by the gateway id keeps it
self-invalidating: correcting the id on the row lets retries resume.

Also log member_id instead of user_id, which the retry query never
returns - every existing entry reads "user_id": "unknown".

Closes #1420

Author: saurab018

modules/membership/includes/Admin/Services/Stripe/StripeService.php

@@ -2908,6 +2908,12 @@ public function retry_subscription( $subscription ) {
 			return $response;
 		}
 
+		if ( ! empty( $subscription['member_id'] ) && get_user_meta( $subscription['member_id'], 'urm_retry_unrecoverable_' . $subscription['sub_id'], true ) ) {
+			$response['message'] = __( 'Subscription no longer exists at Stripe and will not be retried', 'user-registration' );
+
+			return $response;
+		}
+
 		PaymentGatewayLogging::log_general(
 			'stripe',
 			'Retrying Stripe subscription payment' . "\n" . wp_json_encode(
@@ -3047,12 +3053,22 @@ public function retry_subscription( $subscription ) {
 						'error_code'      => $e->getStripeCode(),
 						'error_message'   => $e->getMessage(),
 						'subscription_id' => $subscription['subscription_id'],
-						'user_id'         => $subscription['user_id'] ?? 'unknown',
+						'member_id'       => $subscription['member_id'] ?? 'unknown',
 					),
 					JSON_PRETTY_PRINT
 				)
 			);
 
+			// A missing subscription can never come back (deleted, or created under the other API mode),
+			// so stop the daily cron from retrying this row forever.
+			if ( 'resource_missing' === $e->getStripeCode() && ! empty( $subscription['member_id'] ) ) {
+				update_user_meta(
+					$subscription['member_id'],
+					'urm_retry_unrecoverable_' . $subscription['sub_id'],
+					$e->getMessage()
+				);
+			}
+
 			$response['message'] = $e->getMessage();
 
 			return $response;