Fix - Update subscription reactivation status based on payment completion

Author: MILAN88888

modules/membership/includes/AJAX.php

@@ -1374,10 +1374,16 @@ public static function reactivate_membership() {
 		if ( ! empty( $order_associated_with_subscription_id['order_type'] ) && $order_associated_with_subscription_id['order_type'] === $membership_details['type'] ) {
 			if ( isset( $membership_details['type'] ) && 'subscription' !== $membership_details['type'] ) {
 				$subscription_repository = new SubscriptionRepository();
+
+				// Only restore to 'active' if the order's payment has actually been approved/completed
+				// (e.g. Bank Transfer orders stay 'pending' until an admin approves them); otherwise
+				// restore to 'pending' instead of bypassing the manual payment verification flow.
+				$reactivated_status = ( 'completed' === ( $order_associated_with_subscription_id['status'] ?? '' ) ) ? 'active' : 'pending';
+
 				$subscription_repository->update(
 					$subscription_id,
 					array(
-						'status' => 'active',
+						'status' => $reactivated_status,
 					)
 				);
 

modules/membership/includes/Admin/Repositories/SubscriptionRepository.php

@@ -140,10 +140,16 @@ public function reactivate_subscription_by_id( $subscription_id, $send_email = t
 
 			$subscription_service = new SubscriptionService();
 			$subscription_service->reactivate_subscription( $order, $subscription );
+
+			// Only restore to 'active' if the order's payment has actually been approved/completed
+			// (e.g. Bank Transfer orders stay 'pending' until an admin approves them); otherwise
+			// restore to 'pending' instead of bypassing the manual payment verification flow.
+			$reactivated_status = ( 'completed' === ( $order['status'] ?? '' ) ) ? 'active' : 'pending';
+
 			$result = $this->update(
 				$subscription_id,
 				array(
-					'status' => 'active',
+					'status' => $reactivated_status,
 				)
 			);
 			if ( ! $result ) {