fix(membership): show missing membership field notice only when at least one active membership exists (#1359)

Author: MILAN88888

modules/membership/includes/Admin/Services/MembershipService.php

@@ -548,8 +548,13 @@ private static function verify_membership_registration_form_shortcode( $post, $r
 			}
 		}
 
-		$response['status']           = $membership_field_exists;
-		$response['message']          = ! $membership_field_exists ? __( 'The selected page consist a User Registration & Membership Form but no membership field.', 'user-registration' ) : '';
+		// Warn only when at least one active membership exists, since the field is
+		// pointless with none (see UR-4604).
+		$active_memberships_count = count( ( new MembershipRepository() )->get_all_membership() );
+		$show_notice              = ! $membership_field_exists && $active_memberships_count >= 1;
+
+		$response['status']           = ! $show_notice;
+		$response['message']          = $show_notice ? __( 'The selected page consist a User Registration & Membership Form but no membership field.', 'user-registration' ) : '';
 		$response['disable_save_btn'] = 'no';
 
 		return $response;