fix(ci): define missing hosted-acceptance QA npm scripts (Gates 13, 16, 10–12) - #321
Open
theonlygeranium wants to merge 1 commit into
Open
theonlygeranium wants to merge 1 commit into
theonlygeranium wants to merge 1 commit into
Conversation
Deploying vinifera with
|
| Latest commit: |
ab47a47
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34aa8418.vinifera.pages.dev |
| Branch Preview URL: | https://cursor-fix-hosted-gate-qa-sc.vinifera.pages.dev |
theonlygeranium
marked this pull request as ready for review
August 7, 2026 10:08
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Three gate-acceptance workflows invoke npm scripts that package.json never defined, so their in-CI QA step failed closed: - shipcompliant-staging-acceptance.yml -> qa:gate13-acceptance - gate16-custom-hostname-acceptance.yml -> qa:gate16-acceptance - phase4-hosted-acceptance.yml -> qa:phase4-hosted-acceptance (Gates 10-12) Add each mapping to its existing Vitest suite, matching the established qa:gate6-acceptance / qa:gate14-acceptance convention. No gate status changes; all affected gates remain pending. Verification: npm run qa:gate13-acceptance (11), qa:gate16-acceptance (13), qa:phase4-hosted-acceptance (16) all pass. Co-authored-by: theonlygeranium <theonlygeranium@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/fix-hosted-gate-qa-scripts-fefb
branch
from
August 7, 2026 10:14
ce050fb to
ab47a47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three hosted gate-acceptance workflows invoke
npm runscripts thatpackage.jsonnever defined, so those workflows fail closed at their QA step. This defines the missing scripts, each pointing at its existing Vitest suite, matching the establishedqa:gate6-acceptance/qa:gate14-acceptanceconvention. Chosen as autonomous work that does not overlap the in-flight Gate 8 (Resend) effort..github/workflows/shipcompliant-staging-acceptance.ymlqa:gate13-acceptancevitest run tests/scripts/hosted-gate13-shipcompliant-acceptance.test.mjs.github/workflows/gate16-custom-hostname-acceptance.ymlqa:gate16-acceptancevitest run tests/scripts/hosted-gate16-custom-hostname-acceptance.test.mjs.github/workflows/phase4-hosted-acceptance.ymlqa:phase4-hosted-acceptancevitest run tests/scripts/hosted-phase4-acceptance.test.mjsNo workflow YAML changed (the references already existed); only
package.json+CHANGELOG.md.Why — these workflows would error on
npm run <script>with "missing script", blocking the gate controllers from running their bundled QA in CI. The target test files already exist.Deployment impact: CI / gate-controller wiring only. No application route, provider, database, credential, billing, DNS, or Worker activation change. All affected gates remain
pending— this does not claim or advance any gate.Coordination: Deliberately avoids the Gate 8 / Resend surface (
scripts/hosted-gate8-acceptance.mjs,resend-*,config/resend-*, theci.ymlgate8 job). Gate 8's own QA (qa:resend-provisioning) is already defined, so there is nopackage.jsonoverlap.Type of change
Evidence level
npm run qa:gate13-acceptance→ 11 passednpm run qa:gate16-acceptance→ 13 passednpm run qa:phase4-hosted-acceptance→ 16 passedpackage.jsonvalid JSONnode .github/scripts/delivery-policy.mjs --base origin/dev --head HEAD→ laneoperator-tooling-tested, riskmedium(script keys matchqa:and commands matchvitest, accepted byoperator-tooling-policy.mjs)Classifier and test selection
operator-tooling-testedfast-lane)Logical delivery contract
[Unreleased]changelog entrydevwill squash to one logical Conventional CommitEnvironment and activation
Activation gates affected: None (wiring only; Gates 10–13 and 16 remain pending)
human-review-requirednordo-not-mergeis presentRisks, rollback, and assumptions
Very low risk; adds three test-only npm scripts. Rollback = revert. Assumes the referenced Vitest suites remain the intended QA for those gates (verified present and green).