[Fix] Tests fail intermittently under scheduler and hardware variation - #2
Draft
roomote-researcher-roomote-ai[bot] wants to merge 1 commit into
Draft
roomote-researcher-roomote-ai[bot] wants to merge 1 commit into
roomote-researcher-roomote-ai[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The audio tests and measurement workflow contained timing, hardware, and shared-state assumptions that can fail intermittently under different schedulers or test order. The integration fixture also did not match the current four-value measurement contract.
Impact
The affected tests now use deterministic fixtures and mocks, while production measurement waits on an explicit playback readiness signal instead of an arbitrary delay. Full pytest execution could not be run in this sandbox because
pytestand the project dependencies are unavailable;compileallandgit diff --checkpass.Known flakes not fixed in this PR: external-service and concurrency risks in
Virtual_Therapistarchived LLM integration tests, and hardware interrupt timing inPycharm-MicroPython. They require their external services or hardware to reproduce safely and had no comparable host-only CI evidence.