Replace allow attributes with expect

Author: thorio

gravel-core/src/engine.rs

@@ -102,7 +102,7 @@ impl QueryEngine {
 }
 
 /// Queries providers; aggregates, scores and orders [`ArcDynHit`]s.
-#[allow(single_use_lifetimes)]
+#[expect(single_use_lifetimes)]
 fn query_all<'a>(providers: impl Iterator<Item = &'a ProviderInfo>, query: &str) -> QueryResult {
 	let hits = providers.flat_map(|p| query_one(p, query).hits).collect_vec();
 

gravel-ffi/src/hit.rs

@@ -114,8 +114,6 @@ pub struct SimpleHit {
 	pub title: RString,
 	pub subtitle: RString,
 	pub override_score: ROption<u32>,
-
-	#[allow(clippy::type_complexity)]
 	pub action: SimpleHitAction,
 	pub secondary_action: Option<SimpleHitAction>,
 }

gravel-ffi/src/lib.rs

@@ -4,9 +4,7 @@
 
 // the abi_stable derives/macros generate code that doesn't gel with these lints
 // since you can't just slap these on generated code they're disabled for the whole crate
-#![allow(
-	clippy::empty_docs,
-	clippy::needless_lifetimes,
+#![expect(
 	clippy::used_underscore_binding,
 	non_local_definitions,
 	single_use_lifetimes,

gravel-ffi/src/prefix.rs

@@ -11,7 +11,6 @@ pub struct PluginLib {
 	pub plugin: extern "C" fn(log_target: BoxDynLogTarget) -> RVec<PluginDefinition>,
 }
 
-#[allow(clippy::use_self)]
 impl RootModule for PluginLibRef {
 	declare_root_module_statics! {PluginLibRef}
 

gravel-ffi/tests/cache_test.rs

@@ -1,7 +1,7 @@
 //! Really a unit test, but can't be in-module due to
 //! circular dependency gravel-ffi <-> gravel-test-utils
 
-#![allow(unused_crate_dependencies)]
+#![expect(unused_crate_dependencies)]
 
 use gravel_ffi::{ArcDynHit, HitCache, StaticHitCache};
 use gravel_test_utils::{data::TestHit, util::slices_equal};

gravel-ffi/tests/smoke_test.rs

@@ -1,4 +1,4 @@
-#![allow(unused_crate_dependencies, clippy::missing_panics_doc)]
+#![expect(unused_crate_dependencies, clippy::missing_panics_doc)]
 
 use abi_stable::std_types::{ROption, RSlice, RString};
 use abi_stable::traits::IntoReprC;

gravel-provider-kill/src/windows.rs

@@ -34,7 +34,7 @@ pub enum KillError {
 }
 
 // Needs to be Result to maintain same signature as linux implementation
-#[allow(clippy::unnecessary_wraps)]
+#[expect(clippy::unnecessary_wraps)]
 pub fn query() -> Result<impl Iterator<Item = SimpleHit>> {
 	// TODO: sysinfo crate loads a lot of unnecessary data into memory,
 	// replace with native calls (or a crate that does streaming)

gravel-provider-program/src/linux.rs

@@ -33,7 +33,7 @@ pub fn get_program(path: &Path) -> Option<SimpleHit> {
 fn run_program(desktop_file: &str, context: RefDynHitActionContext<'_>) {
 	log::debug!("starting application '{desktop_file}'");
 
-	#[allow(clippy::zombie_processes)]
+	#[expect(clippy::zombie_processes)]
 	Command::new("gtk-launch")
 		.arg(desktop_file)
 		// explicitly prevent stream inheritance

gravel-provider-program/src/windows.rs

@@ -48,7 +48,7 @@ fn parent_dir(path: RStr<'_>) -> Option<&Path> {
 fn run_explorer(link_path: impl AsRef<OsStr> + Debug, context: RefDynHitActionContext<'_>) {
 	log::debug!("starting explorer with {link_path:?}");
 
-	#[allow(clippy::zombie_processes)]
+	#[expect(clippy::zombie_processes)]
 	Command::new("explorer")
 		.arg(link_path)
 		.spawn()

gravel-provider-system/src/windows.rs

@@ -1,5 +1,5 @@
 // Needs to be Result to maintain same signature as linux implementation
-#![allow(clippy::unnecessary_wraps)]
+#![expect(clippy::unnecessary_wraps)]
 
 use anyhow::Result;
 use winapi::um::{powrprof, winuser};