perf(kv): stage block table with numpy - #132
Open
adamleex wants to merge 1 commit into
Open
Conversation
Build the paged KV block table through a reused NumPy int32 buffer and a persistent torch view. A microbenchmark on H200 shows lower CPU staging and CPU-to-GPU update time than rebuilding padded Python lists with torch.tensor.
Collaborator
|
Thank you for your contribution! But I am wondering why this persistent numpy buffer matters. I thought a malloc of a numpy buffer is much cheaper than the following assignment from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the paged KV block table through a reused NumPy int32 buffer and a persistent torch view. A microbenchmark on H200 shows lower CPU staging and CPU-to-GPU update time than rebuilding padded Python lists with torch.tensor.
Benchmark
Microbenchmark on H200, measuring CPU staging + GPU copy + synchronize: