fix(widget): don't crash when restoring the unread widget configuration

Author: wmontwe

core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt

@@ -164,7 +164,6 @@ data class LegacyAccount(
         return findIdentity(address) != null
     }
 
-    @Synchronized
     fun findIdentity(address: Address): Identity? {
         // Prefer to match by email and name.
         // Fall back to email only if no identity's name matches (e.g. a renamed identity).
@@ -176,7 +175,6 @@ data class LegacyAccount(
         }
     }
 
-    @Synchronized
     fun getIdentity(index: Int): Identity {
         if (index !in identities.indices) throw NoSuchElementException("Identity with index $index not found")
 

feature/widget/unread/src/main/kotlin/app/k9mail/feature/widget/unread/UnreadWidgetConfigurationFragment.kt

@@ -121,7 +121,7 @@ class UnreadWidgetConfigurationFragment : PreferenceFragmentCompat() {
 
     override fun onSaveInstanceState(outState: Bundle) {
         super.onSaveInstanceState(outState)
-        outState.putString(STATE_SELECTED_ACCOUNT_UUID, selectedAccountId.toString())
+        selectedAccountId?.let { outState.putString(STATE_SELECTED_ACCOUNT_UUID, it.toString()) }
         outState.putLongIfPresent(STATE_SELECTED_FOLDER_ID, selectedFolderId)
         outState.putString(STATE_SELECTED_FOLDER_DISPLAY_NAME, selectedFolderDisplayName)
     }

legacy/core/src/main/java/com/fsck/k9/search/LocalSearchExtensions.kt

@@ -31,7 +31,7 @@ fun LocalMessageSearch.getLegacyAccounts(accountManager: LegacyAccountManager):
         accounts
     } else {
         val searchAccountIds = accountIds.toSet()
-        accounts.filter { it.id in searchAccountIds || it.id in searchAccountIds }
+        accounts.filter { it.id in searchAccountIds }
     }
 }