Repository navigation
refactor: Replace Changelog Data Source - #11455
Merged
Merged
Conversation
Contributor
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
shamim-emon
force-pushed
the
fix-issue-11438
branch
5 times, most recently
from
August 26, 2026 16:17
eb768bf to
0707728
Compare
shamim-emon
marked this pull request as draft
August 26, 2026 16:31
shamim-emon
marked this pull request as ready for review
August 26, 2026 16:31
wmontwe
reviewed
Sep 4, 2026
wmontwe
left a comment
Member
There was a problem hiding this comment.
The Android resource shrinker cannot detect the changelog_release_* resources and strips them from a release build. You need to define a keep rule to avoid them being removed.
shamim-emon
force-pushed
the
fix-issue-11438
branch
2 times, most recently
from
September 5, 2026 00:15
103cd09 to
97696af
Compare
shamim-emon
temporarily deployed
to
botmobile
September 5, 2026 05:33 — with
GitHub Actions
Inactive
wmontwe
reviewed
Sep 7, 2026
wmontwe
reviewed
Sep 7, 2026
wmontwe
reviewed
Sep 7, 2026
wmontwe
left a comment
Member
There was a problem hiding this comment.
The changelog module is not backed by tests, despite it does parsing, resource lookup, state tracking etc.
wmontwe
reviewed
Sep 7, 2026
…in/res/raw/ to app-k9mail/src/release/res/raw/
…angelog jsons into app-k9mail/src/release/res/raw/ instead of app-k9mail/src/main/res/raw/
…rc/daily/res/raw/
…rc/debug/res/raw/
shamim-emon
force-pushed
the
fix-issue-11438
branch
from
September 8, 2026 11:45
b3192d9 to
1015c8f
Compare
shamim-emon
temporarily deployed
to
botmobile
September 8, 2026 12:28 — with
GitHub Actions
Inactive
wmontwe
approved these changes
Sep 8, 2026
wmontwe
left a comment
Member
There was a problem hiding this comment.
Thank you! All issues resolved.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the migration of the in-app changelog from the legacy ckChangeLog XML data source to the schema-validated JSON changelog system. Changelog data is now loaded exclusively from raw JSON resources. The
de.cketti.library.changelog:ckchangelog-coredependency is removed from the changelog feature and the legacy UI module. Existing changelog and recent-changes screens keep the same behavior and appearance.What Changes
Migrated historical changelog entries into schema-validated JSON.
Added ChangelogConfigProvider so each app flavor points at its own index resource:
K9ChangelogConfigProvider.TbChangelogConfigProvider.Added ChangelogProvider to read the index, resolve raw resources, and decode JSON with kotlinx.serialization.
Added DTOs (ChangelogIndex, ReleaseEntry, ChangelogRelease, ChangelogNote) and ReleaseItem.
Added ChangelogVersionHistory to replace ckChangeLog’s first-run / last-seen version tracking (still persisted under the existing ckChangeLog_* storage keys so upgrade behavior is preserved).
Added unit tests to verify core cabilities.