Skip to content

feat: modernize SendingMailSettings - #11584

Merged
wmontwe merged 37 commits into
thunderbird:mainfrom
shamim-emon:fix-issue-11041
Oct 14, 2026
Merged

feat: modernize SendingMailSettings#11584
wmontwe merged 37 commits into
thunderbird:mainfrom
shamim-emon:fix-issue-11041

Conversation

@shamim-emon

@shamim-emon shamim-emon commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR migrates the Sending Mail Settings screen from the old XML to Jetpack Compose. It is part of the ongoing Thunderbird for Android UI modernization effort and fully replaces the legacy UI while preserving all existing functionality.

What Changed

  • Added necessary string resources and SendingMailSettingsId.
  • Introduced the full Compose architecture:
    • SendingMailSettingsContract.
    • SendingMailSettingsBuilder.
    • UpdateSendingMailSettings UseCase + implementation.
    • SendingMailSettingsViewModel.
    • SendingMailSettingsContent / SendingMailSettingsScreen.
  • Enable deep links to Composition Defaults and Manage Identities without legacy module imports.
  • Added tests for SendingMailSettingsViewModel, UpdateSendingMail and SendingMailSettingsBuilder behavior.

AI Disclosure

Select one of the following (mandatory)

  • This contribution includes changes assisted by AI.

Contribution Checklist

  • I have read, and I affirm that my contribution adheres to Mozilla’s Community Participation Guidelines
  • This contribution is in Kotlin where possible
  • This contribution does not use merge commits
  • This contribution adheres to the existing codestyle (gradlew spotlessCheck)
  • This contribution does not break existing unit tests (gradlew testDebugUnitTest)
  • This contribution includes tests for any new functionality and maintains tests for any updated functionality

@shamim-emon
shamim-emon requested a review from a team as a code owner September 19, 2026 04:42
@github-actions

github-actions Bot commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Validation Passed: All report and feature-flag labels are correctly set.

@shamim-emon
shamim-emon requested a review from wmontwe September 19, 2026 04:42
@shamim-emon shamim-emon added the report: include Include changes in user-facing reports. label Sep 19, 2026
@shamim-emon
shamim-emon removed the request for review from jbott-tbird September 19, 2026 04:44
@shamim-emon
shamim-emon force-pushed the fix-issue-11041 branch 3 times, most recently from 99fb125 to 02606e5 Compare October 3, 2026 19:03
wmontwe
wmontwe requested changes Oct 13, 2026
View reviewed changes

@wmontwe wmontwe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just some small findings.

Comment thread ...n/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsBuilder.kt
Comment thread ...n/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsBuilder.kt
Comment thread ...n/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsBuilder.kt Outdated
Comment thread legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsFragment.kt
Comment thread ...in/net/thunderbird/feature/account/settings/impl/domain/usecase/UpdateSendingMailSettings.kt Outdated
Comment thread ...in/net/thunderbird/feature/account/settings/impl/domain/usecase/UpdateSendingMailSettings.kt
@thunderbird-botmobile thunderbird-botmobile Bot added the pr-sentinel: needs updates Pull request flagged by PR Sentinel for not following guidelines. label Oct 14, 2026
@shamim-emon
shamim-emon requested a review from wmontwe October 14, 2026 13:13
@thunderbird-botmobile thunderbird-botmobile Bot added pr-sentinel: ready for review Passed all automated PR Sentinel checks. Ready for maintainer review. and removed pr-sentinel: needs updates Pull request flagged by PR Sentinel for not following guidelines. labels Oct 14, 2026
wmontwe
wmontwe approved these changes Oct 14, 2026
View reviewed changes

@wmontwe wmontwe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@wmontwe
wmontwe merged commit 304074f into thunderbird:main Oct 14, 2026
19 checks passed
@wmontwe
wmontwe deployed to botmobile October 14, 2026 15:21 — with GitHub Actions Active
@shamim-emon
shamim-emon deleted the fix-issue-11041 branch October 14, 2026 15:21
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 26 milestone Oct 14, 2026

This branch was successfully deployed

2 active (1 outdated) deployments
botmobile — b5b1c41f Deployed Oct 14, 2026 by wmontwe via pr-merged #596
review — b0d0a559 Deployed Sep 19, 2026 by shamim-emon via label-tb-team #520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees

@wmontwe wmontwe

Labels

pr-sentinel: ready for review Passed all automated PR Sentinel checks. Ready for maintainer review. report: include Include changes in user-facing reports.

Projects

None yet

Milestone

Thunderbird 26

Development

Successfully merging this pull request may close these issues.

Modernize Sending Mail Settings Using Jetpack Compose

3 participants

@shamim-emon @wmontwe @jbott-tbird