Skip to content

feat(db-repository): implement move message in MessageLifecycleRepository - #11611

Open
rafaeltonholo wants to merge 3 commits into
thunderbird:mainfrom
rafaeltonholo:rafaeltonholo/create-message-repositories--c-7f7af18
Open

feat(db-repository): implement move message in MessageLifecycleRepository#11611
rafaeltonholo wants to merge 3 commits into
thunderbird:mainfrom
rafaeltonholo:rafaeltonholo/create-message-repositories--c-7f7af18

Conversation

@rafaeltonholo

@rafaeltonholo rafaeltonholo commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Stack

  1. 3da3110 feat(db-repository): add domain models for messages, attachments, and thread messages #11593 (id: c-9653617)
  2. 4c35913 chore(db-repository): convert message download operations to suspend functions #11604 (id: c-e9f0142)
  3. [detached] 18b15b0 feat(core-architecture): add AsyncDataMapper interface for domain-DTO conversion #11606 (id: c-facc931)
  4. 8a393e3 feat(db-repository): add DefaultMessageDataMapper for legacy-to-domain message conversion #11607 (id: c-9ed62a1)
  5. f12481d feat(db-repository): add MessageQueryRepository for querying messages by criteria #11608 (id: c-be36e42)
  6. f0da3d5 feat(db-repository): implement create message in MessageLifecycleRepository #11609 (id: c-639ad93)
  7. 4f9accc feat(db-repository): implement update message in MessageLifecycleRepository #11610 (id: c-a66bc30)
  8. 168347d feat(db-repository): implement move message in MessageLifecycleRepository (id: c-7f7af18) <-- current
  9. 8506a59 feat(db-repository): implement copy and copyAll in MessageLifecycleRepository #11612 (id: c-145c77c)
  10. b0d9b9f feat(db-repository): replace destroy with destroyAllByServerId and destroyByServerId #11613 (id: c-99f9e08) <- current

Contribution Summary

Linked Issue/Ticket: Part of #11486
RFC / Technical Design (if applicable):

Description

  • Add move(messageId, destinationFolderId, accountId) and moveAll() to MessageLifecycleRepository
  • Implement both in DefaultMessageLifecycleRepository with legacy adapter, mapping store exceptions to UnhandledError
  • Replace MessageStore.moveMessage/moveMessages calls in MessagingController with repository move/moveAll
  • Add move/moveAll tests to DefaultMessageLifecycleRepositoryTest and sent-message move tests to MessagingControllerTest

AI Disclosure

Select one of the following (mandatory)

  • This contribution does not include any changes created or assisted by AI.
  • This contribution includes changes assisted by AI.
  • This contribution includes changes created by AI.

Contribution Checklist

  • I have read and affirm that my contribution adheres to Mozilla’s Community Participation Guidelines
  • This contribution is in Kotlin where possible
  • This contribution does not use merge commits
  • This contribution adheres to the existing codestyle (run gradlew spotlessCheck to check and gradlew spotlessApply to format your source code; will be checked by CI).
  • This contribution does not break existing unit tests (run gradlew testDebugUnitTest; will be checked by CI).
  • This contribution includes tests for any new functionality, and maintains tests for any updated functionality.
  • This contribution adheres to our Engineering process (RFC/Technical Design/ADR)
  • This PR has a descriptive title and body that accurately outlines all changes made, and contains a reference to any issues that it fixes (e.g. Closes #XXX or Fixes #XXX).

@rafaeltonholo
rafaeltonholo requested a review from a team as a code owner September 23, 2026 11:26
@rafaeltonholo rafaeltonholo mentioned this pull request Sep 23, 2026
Open
9 of 11 tasks
@rafaeltonholo rafaeltonholo added report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). pr: stacked Must be used on a PR that is stacked on top of other(s) labels Sep 23, 2026
This was referenced Sep 23, 2026
Open
Open
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label Sep 23, 2026
@rafaeltonholo rafaeltonholo mentioned this pull request Sep 23, 2026
Merged
9 of 11 tasks
This was referenced Sep 23, 2026
Merged
Merged
Merged
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from 2013cce to 168347d Compare September 23, 2026 12:08
@rafaeltonholo rafaeltonholo mentioned this pull request Sep 23, 2026
Open
9 of 11 tasks
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch 12 times, most recently from 51405c0 to f127b25 Compare September 28, 2026 11:15
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch 5 times, most recently from 4de312d to 3f7b972 Compare October 2, 2026 13:02
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from 3f7b972 to e21aeb7 Compare October 5, 2026 16:16
@thunderbird-botmobile thunderbird-botmobile Bot added the pr-sentinel: ready for review Passed all automated PR Sentinel checks. Ready for maintainer review. label Oct 5, 2026
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from e21aeb7 to c69e579 Compare October 5, 2026 16:26
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from c69e579 to f37bc48 Compare October 5, 2026 18:18
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from f37bc48 to dc7f5a2 Compare October 5, 2026 18:26
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from dc7f5a2 to 836d1a8 Compare October 5, 2026 19:45
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from 836d1a8 to 91943fb Compare October 5, 2026 19:55
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from 91943fb to ec3f3aa Compare October 6, 2026 10:50
@rafaeltonholo
feat(db-repository): implement create message in MessageLifecycleRepo…
cadd4f6 
…sitory

- Wire MessageLifecycleRepository into MessagingController for sending messages
- Replace direct MessageStore calls with repository.create() in sendMessage()
- Add DefaultMessageLifecycleRepository implementing create() with legacy adapter logic
- Add messageLifecycleRepository, messageDataMapper, and messageIdLegacyEntityIdFactory dependencies
- Convert domain Message to legacy DTO, save to outbox folder, and initialize outbox state
- Add MessageLifecycleRepository registration in MailMessageModule
- Add feature.mail.message.api dependency to legacy core

GG-ID: c-639ad93
@rafaeltonholo
feat(db-repository): implement update message in MessageLifecycleRepo…
5bd2684 
…sitory

- Add update(message, accountId, folderId) to MessageLifecycleRepository with legacy adapter
- Add MessageAlreadyExists error and duplicate detection in create() via MessageQueryRepository
- Use create/update in K9BackendFolder.saveMessage, recovering from MessageAlreadyExists
- Use create/update in DraftOperations.saveDraftLocally
- Derive legacy download state from message flags in the mapper
- Add update and duplicate-detection tests to DefaultMessageLifecycleRepositoryTest

GG-ID: c-a66bc30

GG-Parent: c-639ad93
@rafaeltonholo
feat(db-repository): implement move message in MessageLifecycleReposi…
2574f14 
…tory

- Add move(messageId, destinationFolderId, accountId) and moveAll() to MessageLifecycleRepository
- Implement both in DefaultMessageLifecycleRepository with legacy adapter, mapping store exceptions to UnhandledError
- Replace MessageStore.moveMessage/moveMessages calls in MessagingController with repository move/moveAll
- Add move/moveAll tests to DefaultMessageLifecycleRepositoryTest and sent-message move tests to MessagingControllerTest

GG-ID: c-7f7af18

GG-Parent: c-a66bc30
@rafaeltonholo
rafaeltonholo force-pushed the rafaeltonholo/create-message-repositories--c-7f7af18 branch from ec3f3aa to 2574f14 Compare October 15, 2026 18:30

This branch was successfully deployed

2 active (1 outdated) deployments
botmobile — 2574f141 Deployed Oct 15, 2026 by rafaeltonholo via PR Sentinel #201
review — 2013cceb Deployed Sep 23, 2026 by rafaeltonholo via label-tb-team #539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe Awaiting requested review from wmontwe wmontwe is a code owner automatically assigned from thunderbird/mobile-android-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@wmontwe wmontwe

Labels

pr: stacked Must be used on a PR that is stacked on top of other(s) pr-sentinel: ready for review Passed all automated PR Sentinel checks. Ready for maintainer review. report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). tb-team Tasks and features handled by project maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafaeltonholo @wmontwe