Skip to content

fix(preference): read settings from the cached storage snapshot to reduce startup reads - #11749

Open
wmontwe wants to merge 1 commit into
thunderbird:mainfrom
wmontwe:fix-preference-storage-startup-reads
Open

fix(preference): read settings from the cached storage snapshot to reduce startup reads#11749
wmontwe wants to merge 1 commit into
thunderbird:mainfrom
wmontwe:fix-preference-storage-startup-reads

Conversation

@wmontwe

@wmontwe wmontwe commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Contribution Summary

Linked Issue/Ticket: Resolves #11750

Description

The preference managers and the changelog read the whole preferences table from disk on every storage access, under the provider lock. A cold start did 55 full reads instead of one. This removes this bottleneck.

AI Disclosure

Select one of the following (mandatory)

  • This contribution does not include any changes created or assisted by AI.
  • This contribution includes changes assisted by AI.
    • AI was used for reviewing the changes
  • This contribution includes changes created by AI.

Stack

  • #11708 feat(account): decouple account management and storage from legacy Preferences
  • #11749 fix(preference): read settings from the cached storage snapshot to reduce startup reads ← current

Commits to review

  • d423bc6 fix(preference): read settings from the cached storage snapshot to reduce startup reads

This PR includes earlier stacked changes because GitHub cannot use a branch from a fork as its base.

@wmontwe
wmontwe requested a review from a team as a code owner October 15, 2026 15:34
@wmontwe
wmontwe requested a review from rafaeltonholo October 15, 2026 15:34
@wmontwe wmontwe added the pr: stacked Must be used on a PR that is stacked on top of other(s) label Oct 15, 2026
@wmontwe wmontwe mentioned this pull request Oct 15, 2026
Merged
1 of 3 tasks
@wmontwe
wmontwe deployed to botmobile October 15, 2026 15:34 — with GitHub Actions Active
@wmontwe
wmontwe deployed to botmobile October 15, 2026 15:34 — with GitHub Actions Active
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Validation Passed: All report and feature-flag labels are correctly set.

@thunderbird-botmobile thunderbird-botmobile Bot added the pr-sentinel: needs updates Pull request flagged by PR Sentinel for not following guidelines. label Oct 15, 2026
@thunderbird-botmobile thunderbird-botmobile Bot added pr-sentinel: ready for review Passed all automated PR Sentinel checks. Ready for maintainer review. and removed pr-sentinel: needs updates Pull request flagged by PR Sentinel for not following guidelines. labels Oct 15, 2026
@wmontwe
wmontwe deployed to botmobile October 15, 2026 15:40 — with GitHub Actions Active
@wmontwe wmontwe added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label Oct 15, 2026
@wmontwe
wmontwe force-pushed the fix-preference-storage-startup-reads branch from d423bc6 to a4f2c55 Compare October 15, 2026 16:22
@wmontwe
wmontwe deployed to botmobile October 15, 2026 16:22 — with GitHub Actions Active
@wmontwe wmontwe removed the pr: stacked Must be used on a PR that is stacked on top of other(s) label Oct 15, 2026

This branch was successfully deployed

2 active (1 outdated) deployments
botmobile — a4f2c551 Deployed Oct 15, 2026 by wmontwe via PR Sentinel #195
review — d423bc6d Deployed Oct 15, 2026 by wmontwe via label-tb-team #607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaeltonholo rafaeltonholo Awaiting requested review from rafaeltonholo rafaeltonholo is a code owner automatically assigned from thunderbird/mobile-android-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@rafaeltonholo rafaeltonholo

Labels

pr-sentinel: ready for review Passed all automated PR Sentinel checks. Ready for maintainer review. report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). tb-team Tasks and features handled by project maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preference managers read the whole preferences table on every access

2 participants

@wmontwe @rafaeltonholo