refactor: apply consistent code formatting and style improvements across the codebase

Author: thunderdew-dawn

fl_controller/FLStudioMCP/device_FLStudioMCP.py

@@ -121,10 +121,8 @@ def OnInit():
             "responses cannot be sent back to the MCP server."
         )
     # Enable track metering
-    try:
+    with contextlib.suppress(Exception):
         device.setHasMeters()
-    except Exception:
-        pass
     # Send a heartbeat immediately so the server doesn't have to wait.
     _emit_heartbeat()
     return
@@ -617,7 +615,7 @@ def _vol_out(norm):
 
 # Mixer-specific fader calibration data (empirically swept)
 MIXER_CALIBRATION = [
-    (0.0000, float('-inf')),
+    (0.0000, float("-inf")),
     (0.0100, -50.3347),
     (0.0200, -44.1829),
     (0.0300, -40.5293),
@@ -734,7 +732,7 @@ def _mixer_db_to_norm(db):
         return 1.0
     for i in range(1, len(MIXER_CALIBRATION) - 1):
         x0, y0 = MIXER_CALIBRATION[i]
-        x1, y1 = MIXER_CALIBRATION[i+1]
+        x1, y1 = MIXER_CALIBRATION[i + 1]
         if y0 <= db <= y1:
             return x0 + (db - y0) * (x1 - x0) / (y1 - y0)
     return 1.0
@@ -772,17 +770,19 @@ def _h_mixer_set_pan(p):
     mixer.setTrackPan(t, _clamp_pan(p["value"]))
     return {"track": t, "pan": round(mixer.getTrackPan(t), 4)}
 
+
 def _h_mixer_set_stereo_sep(p):
     t = int(p["track"])
     val = max(-1.0, min(1.0, float(p["value"])))
     if hasattr(mixer, "setTrackStereoSep"):
         mixer.setTrackStereoSep(t, val)
-    
+
     current = 0.0
     if hasattr(mixer, "getTrackStereoSep"):
         current = round(mixer.getTrackStereoSep(t), 4)
     return {"track": t, "stereo_sep": current}
 
+
 def _h_mixer_get_stereo_sep(p):
     t = int(p["track"])
     current = 0.0
@@ -1097,11 +1097,12 @@ def _h_mixer_get_free_track(p):
             return {"track": int(t)}
     except Exception:
         pass
-    
+
     # Fallback manual scan if getFreeTrack is unavailable or returned a lower track
     start = int(p.get("start", 1))
     for i in range(start, mixer.trackCount()):
-        if i == 0: continue
+        if i == 0:
+            continue
         name = mixer.getTrackName(i)
         if not (name.startswith("Insert ") or name.startswith("Track ")):
             continue
@@ -1771,10 +1772,8 @@ def _h_mixer_get_slot(p):
     mute_fn = getattr(plugins, "getPluginMuteState", None)
     enabled = True
     if mute_fn is not None:
-        try:
+        with contextlib.suppress(Exception):
             enabled = not bool(mute_fn(track, slot))
-        except Exception:
-            pass
     return {
         "track": track,
         "slot": slot,
@@ -1834,12 +1833,12 @@ def _h_mixer_get_eq(p):
         except TypeError:
             # Fallback if FL Studio version does not support mode
             gain = round(mixer.getEqGain(track, b), 4)
-            
+
         try:
             frequency = round(mixer.getEqFrequency(track, b, mode), 4)
         except TypeError:
             frequency = round(mixer.getEqFrequency(track, b), 4)
-            
+
         bands.append(
             {
                 "band": b,
@@ -2052,7 +2051,7 @@ def _h_set_time_sig(p):
         general.setNumerator(num)
         general.setDenominator(den)
     except Exception as e:
-        raise _ClientError(f"failed to set time signature: {e}")
+        raise _ClientError(f"failed to set time signature: {e}") from e
     return _h_get_time_sig({})
 
 
@@ -2145,10 +2144,8 @@ def _h_channel_set_steps(p):
                     except Exception as e:
                         failures.append({"step": step_idx, "param": "pitch", "error": str(e)})
 
-        try:
+        with contextlib.suppress(Exception):
             channels.updateGraphEditor()
-        except Exception:
-            pass
         out = _h_channel_get_steps({"channel": idx, "pattern": target_pattern})
         if failures:
             out["step_param_failures"] = failures

knowledgebase/known_pitfalls/channel_pattern_indexing.json

@@ -2,17 +2,16 @@
   "topic": "FL Studio Channel and Pattern Index Synchronization",
   "date": "2026-06-06",
   "author": "Antigravity",
-  "affected_apis": [
-    "CMD_CHANNEL_ROUTING_SUMMARY",
-    "channel_list",
-    "pattern_list"
-  ],
   "confidence_level": "implementation_verified",
   "context": "When matching channels and patterns for batch configuration operations, using fixed channel indices from routing states led to misaligned patterns when FL Studio's dynamic rack indices shifted.",
   "observation": "channel_list returns a dynamically shifting 'i' index. Split by channel creates patterns directly tied to this dynamic channel index (pattern_index = channel_index + 1). Hardcoding names to indices without matching the names in the current list pass causes off-by-one errors.",
   "result": "Unintentionally renamed patterns or completely missed pattern updates.",
   "recommended_action": "Always verify 'c[\"name\"]' directly to identify the target element before issuing a rename or color command. Derive 'pat_idx = c[\"i\"] + 1' dynamically from the channel_list match.",
   "open_questions": [
     "Is there an internal, immutable UUID-like identifier for Channels or Patterns across the bridge?"
-  ]
-}
+  ],
+  "affected_api": "CMD_CHANNEL_ROUTING_SUMMARY, channel_list, pattern_list",
+  "source_method": "N/A",
+  "tested_values": "N/A",
+  "next_recommended_action": "N/A"
+}

knowledgebase/mastering/mastering_boundaries.json

@@ -71,6 +71,12 @@
       ],
       "confidence_level": "docs_confirmed"
     }
-  ]
-}
-
+  ],
+  "affected_api": "N/A",
+  "observation": "N/A",
+  "tested_values": "N/A",
+  "context": "N/A",
+  "result": "N/A",
+  "open_questions": "N/A",
+  "next_recommended_action": "N/A"
+}

knowledgebase/mixing/mixing_fundamentals.json

@@ -120,5 +120,12 @@
       ],
       "confidence_level": "docs_confirmed"
     }
-  ]
-}
+  ],
+  "affected_api": "N/A",
+  "observation": "N/A",
+  "tested_values": "N/A",
+  "context": "N/A",
+  "result": "N/A",
+  "open_questions": "N/A",
+  "next_recommended_action": "N/A"
+}

knowledgebase/performance/fl_studio_cpu_optimization.json

@@ -131,6 +131,12 @@
       ],
       "confidence_level": "docs_confirmed"
     }
-  ]
-}
-
+  ],
+  "affected_api": "N/A",
+  "observation": "N/A",
+  "tested_values": "N/A",
+  "context": "N/A",
+  "result": "N/A",
+  "open_questions": "N/A",
+  "next_recommended_action": "N/A"
+}

knowledgebase/production/fl_studio_workflow_standards.json

@@ -74,6 +74,12 @@
       ],
       "confidence_level": "docs_confirmed"
     }
-  ]
-}
-
+  ],
+  "affected_api": "N/A",
+  "observation": "N/A",
+  "tested_values": "N/A",
+  "context": "N/A",
+  "result": "N/A",
+  "open_questions": "N/A",
+  "next_recommended_action": "N/A"
+}

knowledgebase/recipes/mix_doctor_fixes.json

@@ -109,5 +109,12 @@
       ],
       "confidence_level": "implementation_verified"
     }
-  ]
-}
+  ],
+  "affected_api": "N/A",
+  "observation": "N/A",
+  "tested_values": "N/A",
+  "context": "N/A",
+  "result": "N/A",
+  "open_questions": "N/A",
+  "next_recommended_action": "N/A"
+}