fix: prioritize Open FL Studio guidance when bridge failure is caused by an unopen application

Author: thunderdew-dawn

src/fls_pilot/control_center.py

@@ -6490,6 +6490,7 @@ def _setup_guidance(
     daemon_process = processes.get("daemon", {})
     daemon_running = _process_running(daemon_process)
     daemon_start_action_shown = False
+    fl_app_needs_action = _group_needs_action(groups, "fl_app")
     autostart_state = str(daemon_autostart.get("state") or "")
     if autostart_state in {"started", "starting", "external", "failed"}:
         daemon_status = _daemon_startup_status(
@@ -6503,7 +6504,7 @@ def _setup_guidance(
             daemon_action_path = "/api/process/daemon/start"
             daemon_action_label = "Start daemon"
             daemon_start_action_shown = True
-        if daemon_status != "OK":
+        if daemon_status != "OK" and not (fl_app_needs_action and daemon_running):
             guidance.append(
                 _guidance_item(
                     title="Daemon startup",
@@ -6555,7 +6556,7 @@ def _setup_guidance(
             )
         )
 
-    if _group_needs_action(groups, "fl_app"):
+    if fl_app_needs_action:
         guidance.append(
             _guidance_item(
                 title="Open FL Studio",
@@ -6570,7 +6571,7 @@ def _setup_guidance(
             )
         )
 
-    if _group_needs_action(groups, "controller"):
+    if _group_needs_action(groups, "controller") and not fl_app_needs_action:
         guidance.append(
             _guidance_item(
                 title="Connect FL Studio to the controller",

tests/test_control_center.py

@@ -466,6 +466,44 @@ def test_setup_guidance_surfaces_mcp_stdio_blocker_without_ok_daemon_card():
     assert stdio["action_label"] == "Re-check"
 
 
+def test_setup_guidance_prioritizes_open_fl_when_bridge_failure_is_derivative():
+    groups = {
+        "environment": [],
+        "fl_app": [
+            _finding("FL Studio Application", "blocker", "failed").to_dict(),
+        ],
+        "midi": [],
+        "controller": [
+            _finding("FL Studio Controller Script", "blocker", "probe_needed").to_dict(),
+        ],
+        "daemon": [
+            _finding("TCP Daemon / Bridge", "blocker", "failed").to_dict(),
+        ],
+        "mcp_stdio": [
+            _finding("MCP stdio Transport", "blocker", "failed").to_dict(),
+        ],
+        "mcp_sse": [],
+        "mcp_apply": [],
+        "optional_dependencies": [],
+        "other": [],
+    }
+
+    guidance = control_center._setup_guidance(
+        groups=groups,
+        readiness={"state": "blocked"},
+        processes={"daemon": {"state": "external"}},
+        ports={"daemon": {"host": "127.0.0.1", "selected_port": 9787}},
+        daemon_autostart={"state": "external", "message": "A daemon is already reachable."},
+        sse_probe={},
+    )
+
+    titles = [item["title"] for item in guidance]
+    assert titles[0] == "Open FL Studio"
+    assert "Daemon startup" not in titles
+    assert "Connect FL Studio to the controller" not in titles
+    assert "Fix MCP stdio startup" in titles
+
+
 def test_setup_guidance_prioritizes_midi_manual_action(monkeypatch):
     findings = [
         _finding("Python Environment"),