Repository navigation
feat(embedding): configurable pooling and task prefixes - #394
Merged
EyJunge1 merged 2 commits intoOct 10, 2026
Merged
Conversation
Allow mean/cls/last_token pooling, custom query/document prefixes, optional dtype override, and known-model presets so bge-m3/e5/Qwen3 work without patching dist. Closes tickernelz#392.
Prefer CONFIG.embeddingDtype over resolveLocalOnnxDtype from tickernelz#393 so explicit config still wins after the upstream merge.
2 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embeddingPooling(mean|cls|last_token),embeddingQueryPrefix/embeddingDocumentPrefix, and optionalembeddingDtypeoverrideembeddingUseTaskPrefixesas the fallback when custom/preset prefixes are unset; document re-embed requirement when pooling/prefixes changeCloses #392
Test plan
bun test(full suite)bun run typecheckbun run checkembeddingModeltoXenova/bge-m3and confirm warmup + search without patchingdist/embeddingPooling/ custom prefixes explicitly and confirm they override presets