Fixes for failed tests

Avoid test hangs by making modal and network waits tolerant of intermittent UI/background activity. In ClinicianDashboardPage.closeBringDataDialog the code now waits at most 7s for the "Bring Data into Tidepool" dialog, skips clicking if it never appears, and uses a bounded wait (10s) for the dialog to hide. In WorkspacesPage the unconditional waitForLoadState('networkidle') was removed because background polling/spinners can prevent networkidle from firing; the existing visibility checks are relied on instead.

Author: Foscottl-TP

page-objects/clinician/ClinicianDashboardPage.ts

@@ -120,12 +120,22 @@ class ClinicianDashboardPage {
   }
 
   /**
-   * Closes the Bring Data into Tidepool dialog by clicking Done.
+   * Dismiss the "Bring Data into Tidepool" dialog if it appears after adding a
+   * patient. This modal is incidental to the add/edit/delete flow, and not every
+   * app build shows it (or shows it on the same timing), so the wait is bounded
+   * and best-effort: if the dialog isn't shown within a few seconds we simply
+   * move on. The previous unbounded `waitFor({ state: 'visible' })` hung until the
+   * whole test timed out whenever the dialog didn't appear.
    */
   async closeBringDataDialog(): Promise<void> {
-    await this.bringDataDialog.waitFor({ state: 'visible' });
+    const appeared = await this.bringDataDialog
+      .waitFor({ state: 'visible', timeout: 7000 })
+      .then(() => true)
+      .catch(() => false);
+    if (!appeared) return;
+
     await this.bringDataDialog_doneButton.click();
-    await this.bringDataDialog.waitFor({ state: 'hidden' });
+    await this.bringDataDialog.waitFor({ state: 'hidden', timeout: 10000 }).catch(() => {});
   }
 
   /**

page-objects/clinician/WorkspacesPage.ts

@@ -39,7 +39,10 @@ export default class WorkspacesPage {
     await this.page.getByRole('button', { name: 'Go To Workspace' }).first().waitFor({
       state: 'visible',
     });
-    await this.page.waitForLoadState('networkidle');
+    // NB: deliberately NOT waiting for 'networkidle'. The app keeps background
+    // activity (polling/analytics/loading spinners) that can prevent networkidle
+    // from ever firing, which hangs this method until the test times out. The two
+    // visibility waits above already confirm the workspaces list has rendered.
   }
 
   async visitFirstClinic(): Promise<void> {