QAE-816 Rendom Invalid Date error fix - #91
Open
Foscottl-TP wants to merge 8 commits into
Open
Conversation
ProfilePage: add a locator for the inline diagnosis-date error (anchored to .PatientInfo-blocks > div:nth-child(3)...) and two helper methods: waitForEditFields (ensure core edit fields are visible) and clickSave (click Save without waiting for the form to close to trigger inline validation). Test: import expect and update the claimed profile test to compute deterministic birth/diagnosis dates and a random notes string, verify the edit fields are visible, submit an invalid diagnosis date (earlier than birth) using clickSave, assert an inline validation error is shown, then correct the date to a valid value and save. These changes exercise the form's on-submit inline validation and the correction path. Note: the diagnosis error selector relies on the 3rd .PatientInfo-blocks child and should be updated if the form structure changes.
Fix error repro from invalid randomized diagnosis date.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds deterministic profile dates and validates that diagnosis dates cannot precede birth dates.
Changes:
- Generates consistent valid and invalid date combinations.
- Tests inline validation before correcting and saving.
- Adds profile-page helpers for edit fields and save behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/claimed/API-Profile/Claimed-EditProfileDetailsAccessConfirm.spec.ts |
Adds invalid-date validation coverage. |
page-objects/patient/ProfilePage.ts |
Adds validation locator and form helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactor LoginPage to handle the Keycloak identity-first (username→password) flow used by the app. - Replace role-based Playwright selectors with explicit Keycloak locators (#username, #password, #kc-login). - Rename properties to usernameInput, passwordInput, submitButton and remove deprecated email/next/login fields. - Implement staged login: wait for username page, submit, wait for password page, submit. Adds explicit waits (15s) to handle redirects to Keycloak. - Preserve viewport sizing and add a note about 2FA/TOTP being handled separately. This makes the login helper robust to the two-step Keycloak flow and the reused submit button id across pages.
Support Keycloak identity-first login flow
Move Login-Validations.spec.ts into tests/clinician as Clinician-Login-Validations.spec.ts. Prefix each test title with "Clinician - " and remove TEST_TAGS.WIP from the test tag arrays. No functional test logic was changed.
Expose usernameError and passwordError locators on LoginPage and use existing page-object locators (usernameInput, submitButton) across clinician login validation tests instead of raw page selectors. Tests now assert error visibility via the page object and update the expected password error text and test detail to reflect "Invalid username or password." This centralizes selectors and improves test clarity and maintainability.
Convert clinician login specs to clearer Given/When/Then style: add explicit step comments, rename test.step titles to BDD phrasing, and add descriptive step.detail metadata. Replace "username" wording with "email" in messages and details, and clarify error assertions (no-account and invalid-credentials cases). These changes improve readability and make test intent and reporting more explicit.
…idation Scott/qae 829/update login validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging previously verified and checked changes to fix the corresponding bug.