Support Keycloak identity-first login flow - #92
Merged
Conversation
Refactor LoginPage to handle the Keycloak identity-first (username→password) flow used by the app. - Replace role-based Playwright selectors with explicit Keycloak locators (#username, #password, #kc-login). - Rename properties to usernameInput, passwordInput, submitButton and remove deprecated email/next/login fields. - Implement staged login: wait for username page, submit, wait for password page, submit. Adds explicit waits (15s) to handle redirects to Keycloak. - Preserve viewport sizing and add a note about 2FA/TOTP being handled separately. This makes the login helper robust to the two-step Keycloak flow and the reused submit button id across pages.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the login page object for Keycloak’s two-step identity-first flow.
Changes:
- Replaces legacy login locators with Keycloak element IDs.
- Separates username and password submission with explicit waits.
- Documents the flow and future 2FA handling.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor LoginPage to handle the Keycloak identity-first (username→password) flow used by the app.
This makes the login helper robust to the two-step Keycloak flow and the reused submit button id across pages.
Pushing to develop to confirm in circleCI for full validation