Scott/qae 829/update login validation - #93
Merged
Conversation
Move Login-Validations.spec.ts into tests/clinician as Clinician-Login-Validations.spec.ts. Prefix each test title with "Clinician - " and remove TEST_TAGS.WIP from the test tag arrays. No functional test logic was changed.
Expose usernameError and passwordError locators on LoginPage and use existing page-object locators (usernameInput, submitButton) across clinician login validation tests instead of raw page selectors. Tests now assert error visibility via the page object and update the expected password error text and test detail to reflect "Invalid username or password." This centralizes selectors and improves test clarity and maintainability.
Convert clinician login specs to clearer Given/When/Then style: add explicit step comments, rename test.step titles to BDD phrasing, and add descriptive step.detail metadata. Replace "username" wording with "email" in messages and details, and clarify error assertions (no-account and invalid-credentials cases). These changes improve readability and make test intent and reporting more explicit.
Contributor
There was a problem hiding this comment.
Pull request overview
Modernizes clinician login validation tests, relocates them to the clinician suite, and adds reusable error locators.
Changes:
- Restructures tests using Given-When-Then steps.
- Moves clinician login tests from the personal suite.
- Adds username and password error locators.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/personal/Login-Validations.spec.ts |
Removes misplaced clinician tests. |
tests/clinician/Clinician-Login-Validations.spec.ts |
Adds reformatted clinician login tests. |
page-objects/LoginPage.ts |
Adds field-level error locators. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
LGTC. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to