Skip to content

WEB 4460 - Table Cells - #2007

Open
henry-tp wants to merge 23 commits into
WEB-4460-filteringfrom
WEB-4460-table
Open

WEB 4460 - Table Cells#2007
henry-tp wants to merge 23 commits into
WEB-4460-filteringfrom
WEB-4460-table

Conversation

@henry-tp

Copy link
Copy Markdown
Contributor

Stack created with GitHub Stacks CLIGive Feedback 💬

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • master
  • main
  • develop
  • release.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 33534316-7fcb-4cf3-8e19-2a2e838baa69

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Summary

Summary by CodeRabbit

  • New Features
    • Added comprehensive Tide Dashboard V2 table views with patient metrics, glucose readings, time-in-range charts, GMI, CGM use, changes over time, flags, tags, review status, and additional actions.
    • Dashboard columns now adapt to the selected patient category and clinic measurement units.
    • Added patient tag display, showing up to three tags per patient.
    • Added flag prioritization and threshold-based indicators for clearer clinical review.

Walkthrough

Changes

Tide Dashboard V2

Layer / File(s) Summary
Cell rendering and flag evaluation
app/pages/clinicworkspace/TideDashboardV2/CGMExclusionQuery.js, app/pages/clinicworkspace/TideDashboardV2/Cells.js, __tests__/unit/app/pages/clinicworkspace/TideDashboardV2/Cells.test.js
Adds metric cells, responsive headers, threshold-based flags, and tests for displayed values, units, percentages, and flag priority.
Category-specific table columns
app/pages/clinicworkspace/components/TagListCell.js, app/pages/clinicworkspace/TideDashboardV2/useTableColumns.js, __tests__/unit/app/pages/clinicworkspace/TideDashboardV2/TideDashboardV2.test.js
Builds category-specific columns, formats glucose thresholds by clinic units, renders patient tags, and tests headers and column counts for each category.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ReduxStore
  participant useTableColumns
  participant TideDashboardV2
  participant CellComponents
  participant TagListCell
  ReduxStore->>useTableColumns: clinic settings and selected clinic
  useTableColumns->>useTableColumns: format thresholds and select category columns
  useTableColumns-->>TideDashboardV2: table column definitions
  TideDashboardV2->>CellComponents: patient summary data
  TideDashboardV2->>TagListCell: patient tag identifiers
  TagListCell->>ReduxStore: patientTags
  TagListCell-->>TideDashboardV2: rendered tags
Loading

Merge Risk: 🔵 Low · up to 0acfe

The PR adds table-cell rendering and localized column definitions, but two bounded UI issues remain: zero TIR deltas may display as '-' and column headers may stay in the previous language after a locale change. The change is mergeable with explicit owner follow-up or acceptance of these risks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only GitHub Stacks metadata and does not explain the table cells, column definitions, flag rules, units, or tests in the changeset. Add a concise description of the implemented table cells and columns, category-specific behavior, flag-rule integration, unit handling, and test updates.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding table cells for issue WEB 4460.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch WEB-4460-table

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@henry-tp
henry-tp force-pushed the WEB-4460-table branch 2 times, most recently from 774c38e to d018445 Compare August 18, 2026 21:38
@henry-tp henry-tp changed the title WEB 4460 - Table Contents WEB 4460 - Table Cells Aug 19, 2026
@henry-tp
henry-tp force-pushed the WEB-4460-table branch 2 times, most recently from 0578ceb to 99920a6 Compare August 20, 2026 23:17
@henry-tp
henry-tp force-pushed the WEB-4460-table branch 2 times, most recently from 0468bb4 to 26743d5 Compare August 25, 2026 00:01
@henry-tp
henry-tp force-pushed the WEB-4460-table branch 2 times, most recently from 1f0d5e4 to dbd2c33 Compare August 27, 2026 22:28
@henry-tp
henry-tp requested a review from krystophv September 4, 2026 21:18
@henry-tp
henry-tp force-pushed the WEB-4460-table branch 2 times, most recently from 5fb87b1 to 1281e01 Compare September 6, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant