Skip to content

WEB-4676 - Rename 'Bring Data into Tidepool' and remove link - #2029

Open
henry-tp wants to merge 2 commits into
developfrom
WEB-4676-data-rename
Open

WEB-4676 - Rename 'Bring Data into Tidepool' and remove link#2029
henry-tp wants to merge 2 commits into
developfrom
WEB-4676-data-rename

Conversation

@henry-tp

@henry-tp henry-tp commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

WEB-4676

@henry-tp henry-tp changed the title WEB-4676 rename and remove link WEB-4676 - Rename 'Bring Data into Tidepool' and remove link Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f305d9da-f993-4aa5-8947-c75eadec42cd

📥 Commits

Reviewing files that changed from the base of the PR and between f23b0cb and 24f1b9d.

📒 Files selected for processing (1)
  • app/components/elements/Button.js

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • UI Updates
    • Renamed “Bring Data into Tidepool” to “Manage Device Connections” in the data connections dialog and related patient action menus.
    • Removed the “Learn more” link from the data connections dialog.
    • Improved alignment for buttons using source-based icons.
    • Existing actions for opening and managing device connections remain unchanged.

Walkthrough

The data connection modal and related action menus now use “Manage Device Connections” instead of “Bring Data into Tidepool”. The related unit tests use the updated labels. Button alignment now handles source-based icons.

Changes

Data connection labels and button alignment

Layer / File(s) Summary
Modal and action label updates
app/components/datasources/DataConnectionsModal.js, app/pages/clinicworkspace/ClinicPatients.js, app/pages/dashboard/TideDashboard.js, test/unit/components/datasources/DataConnectionsModal.test.js, test/unit/pages/TideDashboard.test.js
The modal title and data connection actions use “Manage Device Connections”. Existing identifiers and click behavior remain unchanged. Unit tests use the updated labels.
Source-based icon alignment
app/components/elements/Button.js
Button justification now considers both icon and iconSrc.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 24f1b

This updates data-connection wording, removes the related external link, and aligns buttons containing source-based icons. Existing actions remain unchanged, and no current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 6 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the changeset has no author-provided context beyond the title. Add a short description that explains the renamed device-connection actions, the removed external-data link, and the Button alignment change.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the primary changes: renaming “Bring Data into Tidepool” and removing the link.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch WEB-4676-data-rename

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread app/components/elements/Button.js

@clintonium-119 clintonium-119 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants