Skip to content

WEB-4676 - Rename 'Bring Data into Tidepool' and remove link #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henry-tp wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

WEB-4676 - Rename 'Bring Data into Tidepool' and remove link #2029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f23b0cb
WEB-4676 rename and remove link
henry-tp Sep 4, 2026
24f1b9d
WEB-4676 left-align if iconSrc
henry-tp Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions app/components/datasources/DataConnectionsModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,6 @@ export const DataConnectionsModal = (props) => {
? t('Invite patients to authorize syncing from these accounts. Only available in the US at this time.')
: t('When you connect an account, data can flow into Tidepool without any extra effort. Only available in the US at this time.');

const learnMoreText = selectedClinicId
? t('Learn more.')
: t('Learn more here.');

return (
<>
<Dialog
Expand All @@ -147,7 +143,7 @@ export const DataConnectionsModal = (props) => {
onClose={onClose}
>
<DialogTitle onBack={onBack} onClose={onClose}>
<MediumTitle id="data-connections-title">{t('Bring Data into Tidepool')}</MediumTitle>
<MediumTitle id="data-connections-title">{t('Manage Device Connections')}</MediumTitle>
</DialogTitle>

<DialogContent>
Expand All @@ -159,16 +155,6 @@ export const DataConnectionsModal = (props) => {
<Box mb={3}>
<Body1 sx={{ fontWeight: 'medium'}}>
{dataSourcesText}&nbsp;
<Link
id="data-connections-restrictions-link"
href={URL_TIDEPOOL_EXTERNAL_DATA_CONNECTIONS}
target="_blank"
rel="noreferrer noopener"
sx={{
fontSize: 1,
fontWeight: 'medium',
}}
>{learnMoreText}</Link>
</Body1>

{patientData?.email && patient?.permissions?.custodian && (
Expand Down
2 changes: 1 addition & 1 deletion app/components/elements/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export function Button(props) {
};

let justifyContent = 'center';
if (icon) justifyContent = isLeftIcon ? 'flex-end' : 'flex-start';
if (icon || iconSrc) justifyContent = isLeftIcon ? 'flex-end' : 'flex-start';
Comment thread
clintonium-119 marked this conversation as resolved.

return (
<Flex
Expand Down
4 changes: 2 additions & 2 deletions app/pages/clinicworkspace/ClinicPatients.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,15 +424,15 @@ const MoreMenu = ({
text: t('Edit Patient Details'),
}, {
iconSrc: DataInIcon,
iconLabel: t('Bring Data into Tidepool'),
iconLabel: t('Manage Device Connections'),
iconPosition: 'left',
id: `edit-data-connections-${patient.id}`,
variant: 'actionListItem',
onClick: (_popupState) => {
_popupState.close();
handleEditPatientDataConnections(patient);
},
text: t('Bring Data into Tidepool'),
text: t('Manage Device Connections'),
});

arr.push({
Expand Down
4 changes: 2 additions & 2 deletions app/pages/dashboard/TideDashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,15 @@ const MoreMenu = React.memo(({
text: t('Edit Patient Details'),
}, {
iconSrc: DataInIcon,
iconLabel: t('Bring Data into Tidepool'),
iconLabel: t('Manage Device Connections'),
iconPosition: 'left',
id: `edit-data-connections-${patient.id}`,
variant: 'actionListItem',
onClick: (_popupState) => {
_popupState.close();
handleEditPatientDataConnections(patient);
},
text: t('Bring Data into Tidepool'),
text: t('Manage Device Connections'),
}]), [
handleEditPatient,
patient,
Expand Down
2 changes: 1 addition & 1 deletion test/unit/components/datasources/DataConnectionsModal.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ describe('DataConnectionsModal', () => {
// Dialog portals into document.body
const title = document.getElementById('data-connections-title');
expect(title).to.not.be.null;
expect(title.textContent).to.equal('Bring Data into Tidepool');
expect(title.textContent).to.equal('Manage Device Connections');
});

it('should render patient details', () => {
Expand Down
4 changes: 2 additions & 2 deletions test/unit/pages/TideDashboard.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,9 +665,9 @@ describe('TideDashboard', () => {
// Open menu again
fireEvent.click(moreMenuIcon);

await screen.findAllByText('Bring Data into Tidepool'); // wait for DOM to settle
await screen.findAllByText('Manage Device Connections'); // wait for DOM to settle
const dataConnectionsButton = Array.from(document.querySelectorAll('.action-list-item'))
.find(el => el.textContent.includes('Bring Data into Tidepool'));
.find(el => el.textContent.includes('Manage Device Connections'));
expect(dataConnectionsButton).to.not.be.null;

expect(document.querySelector('#data-connections')).to.be.null;
Expand Down